Skip to content

Commit c7ecfe0

Browse files
authored
CI: build wrapper packages in PR workflow (#2486)
* ci: add build steps for React, Vue, and Angular wrappers * test(combobox): improves flaky tests to update option filtering tests to ensure correct results
1 parent ebd9a37 commit c7ecfe0

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

.github/workflows/build-pr.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,19 @@ jobs:
237237
run: |
238238
yarn workspace @telekom/scale-components build
239239
240+
- name: Build React Wrapper
241+
run: |
242+
yarn workspace @telekom/scale-components-react build
243+
244+
- name: Build Vue Wrapper
245+
run: |
246+
yarn workspace @telekom/scale-components-vue build
247+
248+
- name: Build Angular Wrapper
249+
run: |
250+
yarn workspace @telekom/scale-components process-angular-proxies
251+
yarn workspace @telekom/scale-components-angular build
252+
240253
- name: Check for uncommitted changes
241254
run: |
242255
sh scripts/porcelain.sh

packages/components/src/components/combobox/combobox.e2e.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,10 @@ describe('scale-combobox', () => {
6868
const input = await page.find('scale-combobox >>> .combobox-input');
6969
await input.focus();
7070
await input.type('Re');
71+
await page.waitForChanges();
7172
const options = await page.findAll('scale-combobox >>> .combobox-option');
7273
// Should only show React
73-
expect(options.length).toBeLessThanOrEqual(1);
74+
expect(options.length).toBe(1);
7475
expect(options[0]).toEqualText('React');
7576
});
7677

@@ -213,9 +214,10 @@ describe('scale-combobox', () => {
213214
const input = await page.find('scale-combobox >>> .combobox-input');
214215
await input.focus();
215216
await input.type('st');
217+
await page.waitForChanges();
216218
const options = await page.findAll('scale-combobox >>> .combobox-option');
217-
// Should only show React due to custom filter function
218-
expect(options.length).toBeLessThanOrEqual(1);
219+
// Should only show stte due to custom filter function
220+
expect(options.length).toBe(1);
219221
expect(options[0]).toEqualText('stte');
220222
});
221223

0 commit comments

Comments
 (0)