Skip to content

Potential fix for code scanning alert no. 1: Incomplete string escaping or encoding#47

Merged
zeroc0d3 merged 1 commit into
mainfrom
alert-autofix-1
Jan 5, 2026
Merged

Potential fix for code scanning alert no. 1: Incomplete string escaping or encoding#47
zeroc0d3 merged 1 commit into
mainfrom
alert-autofix-1

Conversation

@zeroc0d3
Copy link
Copy Markdown
Member

@zeroc0d3 zeroc0d3 commented Jan 5, 2026

Potential fix for https://github.com/telemetryflow/telemetryflow-core/security/code-scanning/1

In general, the problem is that string.replace('*', '.*') only replaces the first occurrence of *. To correctly translate glob-style * characters to their regex equivalent .* for all instances, we should use a regular expression with the global (g) flag: string.replace(/\*/g, '.*'). This ensures every asterisk is converted, not just the first. Since **/ is also being removed, we can leave that replacement as-is (it is specific, not a wildcard), or also make it global if needed; the main correctness issue CodeQL flags is the incomplete * replacement.

The best way to fix this without changing intended functionality is to update line 779 in src/standardization/validators/coverage/test-structure-validator.ts:

const pattern = convention.pattern.replace('**/', '').replace('*', '.*');

to use a global replacement for *:

const pattern = convention.pattern.replace('**/', '').replace(/\*/g, '.*');

This keeps the overall logic intact: it strips any leading **/ sequence from the pattern and then replaces all remaining glob asterisks with .* to form a JavaScript regular expression fragment. No new imports or helper methods are required; we only change the second replace call to use a regex. The surrounding creation of new RegExp(pattern) remains the same.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ng or encoding

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@zeroc0d3 zeroc0d3 marked this pull request as ready for review January 5, 2026 06:59
@zeroc0d3 zeroc0d3 merged commit b8d66ec into main Jan 5, 2026
14 of 17 checks passed
@zeroc0d3 zeroc0d3 deleted the alert-autofix-1 branch January 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant