Potential fix for code scanning alert no. 1: Incomplete string escaping or encoding#47
Merged
Conversation
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/telemetryflow/telemetryflow-core/security/code-scanning/1
In general, the problem is that
string.replace('*', '.*')only replaces the first occurrence of*. To correctly translate glob-style*characters to their regex equivalent.*for all instances, we should use a regular expression with the global (g) flag:string.replace(/\*/g, '.*'). This ensures every asterisk is converted, not just the first. Since**/is also being removed, we can leave that replacement as-is (it is specific, not a wildcard), or also make it global if needed; the main correctness issue CodeQL flags is the incomplete*replacement.The best way to fix this without changing intended functionality is to update line 779 in
src/standardization/validators/coverage/test-structure-validator.ts:to use a global replacement for
*:This keeps the overall logic intact: it strips any leading
**/sequence from the pattern and then replaces all remaining glob asterisks with.*to form a JavaScript regular expression fragment. No new imports or helper methods are required; we only change the secondreplacecall to use a regex. The surrounding creation ofnew RegExp(pattern)remains the same.Suggested fixes powered by Copilot Autofix. Review carefully before merging.