fix: Ansible lint for all ansible roles naming convention

Author: zeroc0d3

.github/workflows/ci.yml

@@ -83,6 +83,9 @@ jobs:
       - name: Install ansible-lint
         run: pip install ansible-lint
 
+      - name: Install required collections
+        run: ansible-galaxy collection install community.docker
+
       - name: Lint ansible/
         working-directory: ansible
         run: ansible-lint

ansible-k8s/.ansible-lint

@@ -0,0 +1,10 @@
+---
+exclude_paths:
+  - inventory/group_vars/
+  - inventory/host_vars/
+
+skip_list:
+  - var-naming[no-role-prefix]
+
+use_default_rules: true
+verbosity: 1

ansible-k8s/playbooks/02-post-install.yml

@@ -3,4 +3,4 @@
   hosts: masters[0]
   become: true
   roles:
-    - post-install
+    - post_install

ansible-k8s/roles/helm/tasks/main.yml

@@ -38,6 +38,8 @@
       - "{{ helm_binary }}"
       - repo
       - update
+  changed_when: "'Update Complete' in helm_update_output.stdout"
+  register: helm_update_output
 
 - name: Deploy TelemetryFlow Helm release
   ansible.builtin.command:

ansible-k8s/roles/maintenance/tasks/main.yml

@@ -36,7 +36,7 @@
           - nodes
       changed_when: false
       register: top_result
-      ignore_errors: true
+      failed_when: false
 
     - name: Display cluster health summary
       ansible.builtin.debug:
@@ -75,7 +75,7 @@
         snapshot_name: "telemetryflow-{{ ansible_date_time.iso8601_basic_short }}"
         snapshot_pod: rke2-etcd-{{ groups['masters'][0] }}
       changed_when: true
-      ignore_errors: true
+      failed_when: false
 
     - name: Clean up old backups
       ansible.builtin.find:

…k8s/roles/post-install/defaults/main.yml …k8s/roles/post_install/defaults/main.ymlansible-k8s/roles/post-install/defaults/main.yml renamed to ansible-k8s/roles/post_install/defaults/main.yml ansible-k8s/roles/post-install/defaults/main.yml renamed to ansible-k8s/roles/post_install/defaults/main.yml

@@ -15,7 +15,7 @@
       - wait
       - --for=condition=Ready
       - node
-      --all
+      - --all
       - --timeout={{ kubectl_timeout }}s
   changed_when: false
 
@@ -36,6 +36,7 @@
   vars:
     label: "{{ item[1] }}"
   when: node_labels | length > 0
+  changed_when: true
 
 - name: Apply node taints
   ansible.builtin.command:
@@ -54,6 +55,7 @@
   vars:
     taint: "{{ item }}"
   when: node_taints | length > 0
+  changed_when: true
 
 - name: Display cluster node status
   ansible.builtin.command:

…le-k8s/roles/post-install/tasks/main.yml …le-k8s/roles/post_install/tasks/main.ymlansible-k8s/roles/post-install/tasks/main.yml renamed to ansible-k8s/roles/post_install/tasks/main.yml ansible-k8s/roles/post-install/tasks/main.yml renamed to ansible-k8s/roles/post_install/tasks/main.yml

@@ -23,22 +23,22 @@
   notify: Restart rke2-{{ rke2_node_type }}
 
 - name: Install RKE2 (server)
-  ansible.builtin.environment:
-    INSTALL_RKE2_VERSION: "{{ rke2_version }}"
-    INSTALL_RKE2_CHANNEL: "{{ rke2_channel }}"
   ansible.builtin.command: /tmp/rke2-install.sh
   args:
     creates: "{{ rke2_binary_path }}/rke2"
+  environment:
+    INSTALL_RKE2_VERSION: "{{ rke2_version }}"
+    INSTALL_RKE2_CHANNEL: "{{ rke2_channel }}"
   when: rke2_node_type == 'server'
 
 - name: Install RKE2 (agent)
-  ansible.builtin.environment:
-    INSTALL_RKE2_VERSION: "{{ rke2_version }}"
-    INSTALL_RKE2_CHANNEL: "{{ rke2_channel }}"
-    INSTALL_RKE2_TYPE: agent
   ansible.builtin.command: /tmp/rke2-install.sh
   args:
     creates: "{{ rke2_binary_path }}/rke2"
+  environment:
+    INSTALL_RKE2_VERSION: "{{ rke2_version }}"
+    INSTALL_RKE2_CHANNEL: "{{ rke2_channel }}"
+    INSTALL_RKE2_TYPE: agent
   when: rke2_node_type == 'agent'
 
 - name: Enable and start RKE2 server

…ble-k8s/roles/post-install/vars/main.yml …ble-k8s/roles/post_install/vars/main.ymlansible-k8s/roles/post-install/vars/main.yml renamed to ansible-k8s/roles/post_install/vars/main.yml ansible-k8s/roles/post-install/vars/main.yml renamed to ansible-k8s/roles/post_install/vars/main.yml

@@ -0,0 +1,11 @@
+---
+exclude_paths:
+  - keys/
+  - templates/.gitkeep
+  - host_vars/.gitkeep
+
+skip_list:
+  - var-naming[no-role-prefix]
+
+use_default_rules: true
+verbosity: 1