Skip to content

Commit f2d4f69

Browse files
committed
Refactoring security patch for chmod folder TFO-Go-SDK generator
1 parent 82ffbec commit f2d4f69

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

cmd/generator-restfulapi/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ func runNew(cmd *cobra.Command, args []string) {
347347
}
348348

349349
for _, dir := range dirs {
350-
if err := os.MkdirAll(dir, 0755); err != nil {
350+
if err := os.MkdirAll(dir, 0750); err != nil {
351351
fmt.Fprintf(os.Stderr, "Failed to create directory %s: %v\n", dir, err)
352352
os.Exit(1)
353353
}
@@ -404,7 +404,7 @@ func runNew(cmd *cobra.Command, args []string) {
404404
generateFromTemplate("pkg/response.go.tpl", data, filepath.Join(projectRoot, "pkg", "response", "response.go"))
405405

406406
// Create safefile package directory
407-
if err := os.MkdirAll(filepath.Join(projectRoot, "pkg", "safefile"), 0755); err != nil {
407+
if err := os.MkdirAll(filepath.Join(projectRoot, "pkg", "safefile"), 0750); err != nil {
408408
fmt.Fprintf(os.Stderr, "Failed to create safefile directory: %v\n", err)
409409
}
410410
generateFromTemplate("pkg/safefile.go.tpl", data, filepath.Join(projectRoot, "pkg", "safefile", "safefile.go"))
@@ -537,7 +537,7 @@ func generateFromTemplate(templateName string, data interface{}, outputPath stri
537537
// Sanitize the output path to prevent path traversal (G304)
538538
cleanPath := filepath.Clean(outputPath)
539539

540-
if err := os.MkdirAll(filepath.Dir(cleanPath), 0755); err != nil {
540+
if err := os.MkdirAll(filepath.Dir(cleanPath), 0750); err != nil {
541541
fmt.Fprintf(os.Stderr, "Failed to create directory for %s: %v\n", cleanPath, err)
542542
return
543543
}

cmd/generator/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ func runInit(cmd *cobra.Command, args []string) {
135135
}
136136

137137
for _, dir := range dirs {
138-
if err := os.MkdirAll(dir, 0755); err != nil {
138+
if err := os.MkdirAll(dir, 0750); err != nil {
139139
fmt.Fprintf(os.Stderr, "Failed to create directory %s: %v\n", dir, err)
140140
os.Exit(1)
141141
}

tests/unit/generator/basic/generator_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ func TestDirectoryCreation(t *testing.T) {
136136

137137
// Create directories
138138
for _, dir := range dirs {
139-
err := os.MkdirAll(dir, 0755)
139+
err := os.MkdirAll(dir, 0750)
140140
require.NoError(t, err)
141141
}
142142

@@ -160,11 +160,11 @@ func TestDirectoryCreation(t *testing.T) {
160160
dir := filepath.Join(tmpDir, "telemetry")
161161

162162
// Create directory first time
163-
err = os.MkdirAll(dir, 0755)
163+
err = os.MkdirAll(dir, 0750)
164164
require.NoError(t, err)
165165

166166
// Should not error on second creation
167-
err = os.MkdirAll(dir, 0755)
167+
err = os.MkdirAll(dir, 0750)
168168
require.NoError(t, err)
169169
})
170170
}

tests/unit/generator/restapi/restapi_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ func TestProjectFileGeneration(t *testing.T) {
651651
}
652652

653653
for _, dir := range dirs {
654-
err := os.MkdirAll(dir, 0755)
654+
err := os.MkdirAll(dir, 0750)
655655
require.NoError(t, err)
656656
}
657657

tests/unit/infrastructure/template/template_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ func TestTemplateFileOperations(t *testing.T) {
242242
outputPath := filepath.Join(tmpDir, "test", "output.go")
243243

244244
// Create directory structure
245-
err := os.MkdirAll(filepath.Dir(outputPath), 0755)
245+
err := os.MkdirAll(filepath.Dir(outputPath), 0750)
246246
require.NoError(t, err)
247247

248248
// Create file
@@ -285,7 +285,7 @@ func TestTemplateFileOperations(t *testing.T) {
285285
tmpDir := t.TempDir()
286286
nestedPath := filepath.Join(tmpDir, "a", "b", "c", "file.go")
287287

288-
err := os.MkdirAll(filepath.Dir(nestedPath), 0755)
288+
err := os.MkdirAll(filepath.Dir(nestedPath), 0750)
289289
require.NoError(t, err)
290290

291291
err = os.WriteFile(nestedPath, []byte("content"), 0644)

0 commit comments

Comments
 (0)