feat/cli#572
Conversation
Codecov Report
@@ Coverage Diff @@
## development #572 +/- ##
============================================
Coverage 70.91% 70.91%
============================================
Files 208 208
Lines 7561 7561
Branches 2113 2113
============================================
Hits 5362 5362
Misses 2022 2022
Partials 177 177
Continue to review full report at Codecov.
|
JayaKrishnaNamburu
force-pushed
the
feat/cli-beta
branch
from
e5037f9 to
bf64ae4
Compare
…fixes in project generator
| } | ||
|
|
||
| export const BASE_URL = 'https://us-central1-croapp-dev.cloudfunctions.net/repl-api/' | ||
| export const STUDIO_URL = 'https://playground-api-production-v5.services.teleporthq.io/project/' |
There was a problem hiding this comment.
Shouldn't this URL be the frontend one?
There was a problem hiding this comment.
If not, it's a little tricky, because we might upgrade the backend in the future, let's say from v5 to v6.
There was a problem hiding this comment.
So in that case, an old version of the CLI will not work anymore
| import { getPackageJSON } from '../utils' | ||
|
|
||
| export const fetchUIDLFromREPL = async (url: string): Promise<Record<string, unknown>> => { | ||
| const id = url.match(UUDID_REGEX)[0] |
There was a problem hiding this comment.
I think here is better to use this https://www.npmjs.com/package/uuid#uuidvalidatestr
|
And please a minimal Readme in teleport-mapper |
JayaKrishnaNamburu
force-pushed
the
feat/cli-beta
branch
from
f2c8c2e to
4717bdd
Compare
2 participants
No description provided.