Support Dynamic values and Expression as operand of a Conditional Element#960
Open
vladgrecu wants to merge 1 commit into
Open
Support Dynamic values and Expression as operand of a Conditional Element#960vladgrecu wants to merge 1 commit into
vladgrecu wants to merge 1 commit into
Conversation
…onditional Element
| } | ||
|
|
||
| if (value.type === 'dynamic') { | ||
| return `${identifier} ${operation} ${value.content.id}` |
Member
There was a problem hiding this comment.
For dynamic. If i remember correct we need to use options.dynamicPrefix to prefix the value with props by default or with a different name when needed.
Member
Author
There was a problem hiding this comment.
I'm actually thinking that we don't even need to treat this flow. In what code generation pipeline is it used? For non React frameworks?
Member
There was a problem hiding this comment.
Even for reach framework too, in content.id we store only the id value. So, using dynamicPrefix we can get generated code like props.id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/teleporthq/issue/THQ-4151/[code-generators]-support-dynamic-values-and-expression-as-operand-of