Skip to content

Commit 8d355b7

Browse files
committed
Address code review comments.
1 parent f32ca1d commit 8d355b7

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/deploy-docs.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ permissions:
1313
pages: write
1414
id-token: write
1515

16-
# Only allow one deployment at a time; do not cancel in-progress deployments
16+
# Only allow one deployment at a time; cancel in-progress deployments
1717
concurrency:
1818
group: "pages"
19-
cancel-in-progress: false
19+
cancel-in-progress: true
2020

2121
jobs:
2222
build:
@@ -60,9 +60,10 @@ jobs:
6060
path: site
6161

6262
deploy:
63-
environment:
64-
name: github-pages
65-
url: ${{ steps.deployment.outputs.page_url }}
63+
needs: build
64+
name: github-pages
65+
url: ${{ steps.deployment.outputs.page_url }}
66+
if: github.event_name == 'push'
6667
runs-on: ubuntu-latest
6768
needs: build
6869
steps:

docs/dev/index.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
This is the doxygen docs
1+
This file will be overwritten by the deploy-docs action to become the index.html
2+
of the doxygen docs

0 commit comments

Comments
 (0)