Fix

Author: brendt

packages/database/src/Connection/ConnectionReset.php

@@ -15,11 +15,15 @@ public function __construct(
 
     public function reset(): void
     {
+        // Manually looping over the connection singletons so that we can check whether they still have an active transaction
         if ($this->container instanceof GenericContainer) {
-            /** @var Connection[] $connections */
             $connections = $this->container->getSingletons(Connection::class);
 
             foreach ($connections as $connection) {
+                if (! $connection instanceof Connection) {
+                    continue;
+                }
+
                 if ($connection->inTransaction()) {
                     throw new CouldNotResetConnection("There's still an active transaction, make sure to close it before ending the request");
                 }

tests/Integration/Database/Connection/ConnectionResetTest.php

@@ -2,6 +2,7 @@
 
 namespace Tests\Tempest\Integration\Database\Connection;
 
+use Exception;
 use PHPUnit\Framework\Attributes\Test;
 use Tempest\Database\Connection\Connection;
 use Tempest\Database\Exceptions\CouldNotResetConnection;
@@ -38,4 +39,22 @@ public function test_properly_closed_transaction_can_reset_connection(): void
         $newConnection = $this->container->get(Connection::class);
         $this->assertNotSame($connection, $newConnection);
     }
+
+    #[Test]
+    public function test_reset_with_uninstantiated_singletons(): void
+    {
+        $this->container->singleton(
+            Connection::class,
+            fn () => throw new Exception('Should not happen'),
+            tag: 'other',
+        );
+
+        /** @var Connection $connection */
+        $connection = $this->container->get(Connection::class);
+
+        $this->container->reset();
+
+        $newConnection = $this->container->get(Connection::class);
+        $this->assertNotSame($connection, $newConnection);
+    }
 }