chore: minor clean up and phpstan fixes

Author: innocenzi

packages/console/src/ConsoleArgument.php

@@ -20,7 +20,7 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
         public ?string $prompt = null,
-        public string $help = '',
+        public ?string $help = null,
         public array $aliases = [],
     ) {}
 }

packages/core/src/Commands/InstallCommand.php

@@ -47,7 +47,9 @@ public function __invoke(
             $installer = $this->resolveInstaller($installer);
 
             if (! $installer instanceof InstallerDefinition) {
-                $this->error('The provided installer was not found.');
+                $this->console->writeln();
+                $this->console->error('The provided installer was not found.');
+
                 return;
             }
 
@@ -86,7 +88,7 @@ private function resolveInstallerArguments(InstallerDefinition $installer): ?arr
             $installerArgumentBag = $this->buildInstallerArgumentBag();
             $argumentDefinitions = $this->buildInstallerArgumentDefinitions($installer);
 
-            do {
+            while (true) {
                 [$validArguments, $invalidArguments] = ($this->resolveConsoleInput)(
                     argumentBag: $installerArgumentBag,
                     argumentDefinitions: $argumentDefinitions,
@@ -114,7 +116,7 @@ private function resolveInstallerArguments(InstallerDefinition $installer): ?arr
                         argumentDefinition: $argumentDefinition,
                     );
                 }
-            } while ($invalidArguments !== []);
+            }
 
             return array_map(
                 callback: fn (ConsoleInputArgument $argument) => $argument->value,

packages/core/src/Installer.php

@@ -6,6 +6,9 @@
 
 use Attribute;
 
+/**
+ * Defines an installer that will be available as an option when using the `install` console command.
+ */
 #[Attribute(Attribute::TARGET_METHOD)]
 final readonly class Installer
 {

packages/core/src/InstallerDefinition.php

@@ -5,9 +5,9 @@
 namespace Tempest\Core;
 
 use Tempest\Reflection\MethodReflector;
+use Tempest\Support\Str;
 
 use function Tempest\Support\arr;
-use function Tempest\Support\Str\to_kebab_case;
 
 final class InstallerDefinition
 {
@@ -38,7 +38,7 @@ public function __construct(
     public array $aliases {
         get => $this->aliases ??= arr($this->installer->alias)
             ->push($this->handler->getDeclaringClass()->getName())
-            ->push(to_kebab_case($this->name))
+            ->push(Str\to_kebab_case($this->name))
             ->filter()
             ->unique()
             ->toArray();

packages/http/src/Session/Installer/SessionInstaller.php

@@ -27,12 +27,18 @@ public function install(
         ?SessionStorage $storage = null,
         ?bool $migrate = null,
     ): void {
+        /** @var null|SessionStorage $storage */
         $storage ??= $this->console->ask(
             question: 'Which session storage do you want to use?',
             options: SessionStorage::class,
             default: SessionStorage::FILE,
         );
 
+        if (! $storage instanceof SessionStorage) {
+            $this->console->error('Invalid session storage selected.');
+            return;
+        }
+
         $cleanupStrategy = match ($storage) {
             SessionStorage::REDIS => null,
             default => $this->resolveCleanupStrategy(),
@@ -67,7 +73,7 @@ public function install(
         }
     }
 
-    private function resolveCleanupStrategy(): ?CleanupStrategy
+    private function resolveCleanupStrategy(): CleanupStrategy
     {
         $strategy = [
             'Random requests' => CleanupStrategy::RANDOM_REQUESTS,
@@ -84,13 +90,13 @@ private function resolveCleanupStrategy(): ?CleanupStrategy
         return $strategy[$result];
     }
 
-    private function resolveSessionConfigStub(SessionStorage $sessionStrategy, ?CleanupStrategy $cleanupStrategy): string
+    private function resolveSessionConfigStub(SessionStorage $storage, ?CleanupStrategy $cleanupStrategy): string
     {
-        if ($sessionStrategy === SessionStorage::REDIS) {
+        if ($storage === SessionStorage::REDIS) {
             return __DIR__ . '/session.redis.config.stub.php';
         }
 
-        return match ([$sessionStrategy, $cleanupStrategy]) {
+        return match ([$storage, $cleanupStrategy]) {
             [SessionStorage::FILE, CleanupStrategy::EVERY_REQUEST] => __DIR__ . '/session.file.every-request.config.stub.php',
             [SessionStorage::FILE, CleanupStrategy::RANDOM_REQUESTS] => __DIR__ . '/session.file.random-requests.config.stub.php',
             [SessionStorage::FILE, CleanupStrategy::DISABLED] => __DIR__ . '/session.file.disabled.config.stub.php',

packages/http/src/Session/Installer/SessionStorage.php

@@ -4,6 +4,7 @@
 
 namespace Tempest\Http\Session\Installer;
 
+/** @internal */
 enum SessionStorage: string
 {
     case FILE = 'file';