rector + mago fmt applied

Author: xHeaven

packages/auth/src/AccessControl/PolicyBasedAccessControl.php

@@ -13,6 +13,7 @@
 use Tempest\Reflection\ParameterReflector;
 use Tempest\Support\Arr\ImmutableArray;
 use Tempest\Support\Str;
+use Throwable;
 use UnitEnum;
 
 /**
@@ -45,7 +46,7 @@ public function isGranted(UnitEnum|string $action, object|string $resource, ?obj
             throw new NoPolicyWereFoundForResource($resource);
         }
 
-        $resource = ! is_object($resource) ? null : $resource;
+        $resource = is_object($resource) ? $resource : null;
 
         foreach ($policies as $policy) {
             $decision = $this->evaluatePolicy($policy, $resource, $subject);
@@ -60,13 +61,13 @@ public function isGranted(UnitEnum|string $action, object|string $resource, ?obj
 
     private function resolveSubject(?object $subject): ?object
     {
-        if ($subject) {
+        if ($subject !== null) {
             return $subject;
         }
 
         try {
             return $this->container->get(Authenticator::class)->current();
-        } catch (\Throwable) {
+        } catch (Throwable) {
             return null;
         }
     }
@@ -113,9 +114,9 @@ private function evaluatePolicy(MethodReflector $policy, ?object $resource, ?obj
         return AccessDecision::from($decision);
     }
 
-    private function ensureParameterAcceptsInput(?ParameterReflector $reflector, mixed $input, \Closure $throw): void
+    private function ensureParameterAcceptsInput(?ParameterReflector $reflector, mixed $input, Closure $throw): void
     {
-        if ($reflector === null || $input === null) {
+        if (! $reflector instanceof ParameterReflector || $input === null) {
             return;
         }
 

packages/auth/src/Authentication/Authenticatable.php

@@ -7,6 +7,4 @@
 /**
  * Represents an entity that may be authenticated.
  */
-interface Authenticatable
-{
-}
+interface Authenticatable {}

packages/auth/src/Authentication/SessionAuthenticator.php

@@ -10,6 +10,7 @@
 final readonly class SessionAuthenticator implements Authenticator
 {
     public const string AUTHENTICATABLE_KEY = '#authenticatable:id';
+
     public const string AUTHENTICATABLE_CLASS = '#authenticatable:class';
 
     public function __construct(
@@ -35,6 +36,7 @@ public function deauthenticate(): void
     {
         $this->session->remove(self::AUTHENTICATABLE_KEY);
         $this->session->remove(self::AUTHENTICATABLE_CLASS);
+
         $this->sessionManager->save($this->session);
     }
 

packages/auth/src/Exceptions/AuthenticationException.php

@@ -2,6 +2,4 @@
 
 namespace Tempest\Auth\Exceptions;
 
-interface AuthenticationException
-{
-}
+interface AuthenticationException {}

packages/auth/src/Exceptions/NoPolicyWereFoundForResource.php

@@ -9,6 +9,6 @@ final class NoPolicyWereFoundForResource extends Exception implements Authentica
     public function __construct(
         public readonly string|object $resource,
     ) {
-        parent::__construct(sprintf('No policies were found for resource `%s`.', is_object($resource) ? get_class($resource) : $resource));
+        parent::__construct(sprintf('No policies were found for resource `%s`.', is_object($resource) ? $resource::class : $resource));
     }
 }

packages/auth/src/Exceptions/OAuthStateWasInvalid.php

@@ -6,6 +6,4 @@
 
 use Exception;
 
-final class OAuthStateWasInvalid extends Exception implements AuthenticationException
-{
-}
+final class OAuthStateWasInvalid extends Exception implements AuthenticationException {}

packages/auth/src/Installer/AuthenticationInstaller.php

@@ -7,6 +7,7 @@
 use Tempest\Console\Console;
 use Tempest\Console\ConsoleCommand;
 use Tempest\Console\Input\ConsoleArgumentBag;
+use Tempest\Console\Input\ConsoleInputArgument;
 use Tempest\Container\Container;
 use Tempest\Core\Installer;
 use Tempest\Core\PublishesFiles;
@@ -47,7 +48,7 @@ private function shouldMigrate(): bool
         {
             $argument = $this->consoleArgumentBag->get('migrate');
 
-            if ($argument === null || ! is_bool($argument->value)) {
+            if (! $argument instanceof ConsoleInputArgument || ! is_bool($argument->value)) {
                 return $this->console->confirm('Do you want to execute migrations?', default: false);
             }
 
@@ -58,7 +59,7 @@ private function shouldInstallOAuth(): bool
         {
             $argument = $this->consoleArgumentBag->get('oauth');
 
-            if ($argument === null || ! is_bool($argument->value)) {
+            if (! $argument instanceof ConsoleInputArgument || ! is_bool($argument->value)) {
                 return $this->console->confirm('Do you want to install OAuth?', default: false);
             }
 

packages/auth/src/Installer/OAuthInstaller.php

@@ -30,7 +30,7 @@ public function install(): void
     {
         $providers = $this->getProviders();
 
-        if (count($providers) === 0) {
+        if ($providers === []) {
             return;
         }
 

packages/auth/src/OAuth/OAuthConfig.php

@@ -14,32 +14,24 @@ interface OAuthConfig extends HasTag
     /**
      * The OAuth provider class name.
      */
-    public string $provider {
-        get;
-    }
+    public string $provider { get; }
 
     /**
      * The authorization scopes for this OAuth provider.
      *
      * @return string[]
      */
-    public array $scopes {
-        get;
-    }
+    public array $scopes { get; }
 
     /**
      * The client ID for the OAuth provider.
      */
-    public string $clientId {
-        get;
-    }
+    public string $clientId { get; }
 
     /**
      * The controller action to redirect to after the user authorizes the application.
      */
-    public string|array $redirectTo {
-        get;
-    }
+    public string|array $redirectTo { get; }
 
     /**
      * Creates the OAuth provider instance.

packages/auth/tests/AuthenticationAndOAuthSafetyTest.php

@@ -9,6 +9,7 @@
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
 use ReflectionMethod;
+use stdClass;
 use Tempest\Auth\Authentication\DatabaseAuthenticatableResolver;
 use Tempest\Auth\Exceptions\ModelWasNotAuthenticatable;
 use Tempest\Auth\OAuth\GenericOAuthClient;
@@ -23,7 +24,7 @@ public function database_authenticatable_resolver_rejects_non_authenticatable_cl
 
         $this->expectException(ModelWasNotAuthenticatable::class);
 
-        $resolve->invoke($resolver, 1, \stdClass::class);
+        $resolve->invoke($resolver, 1, stdClass::class);
     }
 
     #[Test]