feat(auth): add scopeSeparator parameter to GenericOAuthConfig (#2119)

Author: iNaD

docs/2-features/17-oauth.md

@@ -204,6 +204,7 @@ return new GenericOAuthConfig(
     urlAccessToken: 'https://provider.com/oauth/token',
     urlResourceOwnerDetails: 'https://provider.com/api/user',
     scopes: ['read:user'],
+    scopeSeparator: ' ', // Optional: If omitted the default `,` will be used. OIDC uses a space as separator.
 );
 ```
 

packages/auth/src/OAuth/Config/GenericOAuthConfig.php

@@ -58,6 +58,11 @@ public function __construct(
          * Identifier for this OAuth configuration.
          */
         public null|string|UnitEnum $tag = null,
+
+        /**
+         * Separator for the scopes, defaults to `,` if omitted.
+         */
+        public ?string $scopeSeparator = null,
     ) {}
 
     public function createProvider(): AbstractProvider
@@ -68,6 +73,7 @@ public function createProvider(): AbstractProvider
             'urlAuthorize' => $this->urlAuthorize,
             'urlAccessToken' => $this->urlAccessToken,
             'urlResourceOwnerDetails' => $this->urlResourceOwnerDetails,
+            'scopeSeparator' => $this->scopeSeparator,
         ]);
     }
 

packages/auth/tests/OAuthTest.php

@@ -232,6 +232,43 @@ public function generic_config_maps_user_data(): void
         $this->assertSame('https://example.com/himmel.jpg', $user->avatar);
         $this->assertSame('generic', $user->provider);
     }
+
+    #[Test]
+    public function generic_config_creates_provider_correctly(): void
+    {
+        $config = new GenericOAuthConfig(
+            clientId: 'client-123',
+            clientSecret: 'secret-456', // @mago-expect lint:no-literal-password
+            redirectTo: 'https://example.com/callback',
+            urlAuthorize: 'https://provider.com/authorize',
+            urlAccessToken: 'https://provider.com/token', // @mago-expect lint:no-literal-password
+            urlResourceOwnerDetails: 'https://provider.com/user',
+        );
+
+        $provider = $config->createProvider();
+
+        $url = $provider->getAuthorizationUrl(['scope' => ['scope1', 'scope2']]);
+        $this->assertStringContainsString('https://provider.com/authorize?', $url);
+        $this->assertStringContainsString('scope=scope1%2Cscope2', $url);
+        $this->assertStringContainsString('client_id=client-123', $url);
+
+        $config = new GenericOAuthConfig(
+            clientId: 'client-123',
+            clientSecret: 'secret-456', // @mago-expect lint:no-literal-password
+            redirectTo: 'https://example.com/callback',
+            urlAuthorize: 'https://provider.com/authorize',
+            urlAccessToken: 'https://provider.com/token', // @mago-expect lint:no-literal-password
+            urlResourceOwnerDetails: 'https://provider.com/user',
+            scopeSeparator: ' ',
+        );
+
+        $provider = $config->createProvider();
+
+        $url = $provider->getAuthorizationUrl(['scope' => ['scope1', 'scope2']]);
+        $this->assertStringContainsString('https://provider.com/authorize?', $url);
+        $this->assertStringContainsString('scope=scope1%20scope2', $url);
+        $this->assertStringContainsString('client_id=client-123', $url);
+    }
 }
 
 final class ResourceOwner implements ResourceOwnerInterface