feat(database): autodetect char size by default value

Author: regnerisch

packages/database/src/QueryStatements/CharStatement.php

@@ -19,11 +19,11 @@ public function __construct(
     public function compile(DatabaseDialect $dialect): string
     {
         return sprintf(
-            '%s CHAR(%s) %s %s',
+            '%s CHAR(%s)%s%s',
             $dialect->quoteIdentifier($this->name),
-            $this->size,
-            $this->default !== null ? "DEFAULT '{$this->default}'" : '',
-            $this->nullable ? '' : 'NOT NULL',
+            $this->size === 1 && $this->default !== null ? mb_strlen($this->default) : $this->size,
+            $this->default !== null ? " DEFAULT '{$this->default}'" : '',
+            $this->nullable ? '' : ' NOT NULL',
         );
     }
 }

packages/database/tests/QueryStatements/CharStatementTest.php

@@ -25,4 +25,31 @@ public function test_char(): void
         $this->assertSame($expectedMysql, $statement->compile(DatabaseDialect::MYSQL));
         $this->assertSame($expectedPgsql, $statement->compile(DatabaseDialect::POSTGRESQL));
     }
+
+    #[Test]
+    public function test_determine_char_size(): void
+    {
+        $fixedSizeStatement = new CharStatement(
+            name: 'foo',
+            size: 10,
+        );
+        $expectedMysql = '`foo` CHAR(10) NOT NULL';
+        $this->assertSame($expectedMysql, $fixedSizeStatement->compile(DatabaseDialect::MYSQL));
+
+        $defaultSizeStatement = new CharStatement(
+            name: 'foo',
+            size: 1,
+            default: 'foo_bar',
+        );
+        $expectedMysql = '`foo` CHAR(7) DEFAULT \'foo_bar\' NOT NULL';
+        $this->assertSame($expectedMysql, $defaultSizeStatement->compile(DatabaseDialect::MYSQL));
+
+        $fixedAndDefaultSizeStatement = new CharStatement(
+            name: 'foo',
+            size: 10,
+            default: 'foo_bar',
+        );
+        $expectedMysql = '`foo` CHAR(10) DEFAULT \'foo_bar\' NOT NULL';
+        $this->assertSame($expectedMysql, $fixedAndDefaultSizeStatement->compile(DatabaseDialect::MYSQL));
+    }
 }