Rector wip

Author: brendt

packages/upgrade/config/sets/tempest34.php

@@ -4,10 +4,12 @@
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Tempest\Upgrade\Tempest34\UpdateDiscoveryImportsRector;
+use Tempest\Upgrade\Tempest34\UpdateKernelDiscoveryPropertiesRector;
 
 return static function (RectorConfig $config): void {
     SimpleParameterProvider::setParameter(Option::AUTO_IMPORT_NAMES, value: true);
     SimpleParameterProvider::setParameter(Option::IMPORT_SHORT_CLASSES, value: true);
 
     $config->rule(UpdateDiscoveryImportsRector::class);
+    $config->rule(UpdateKernelDiscoveryPropertiesRector::class);
 };

packages/upgrade/src/Tempest34/UpdateKernelDiscoveryPropertiesRector.php

@@ -0,0 +1,63 @@
+<?php
+
+namespace Tempest\Upgrade\Tempest34;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\PropertyFetch;
+use PhpParser\Node\Identifier;
+use Rector\Rector\AbstractRector;
+
+final class UpdateKernelDiscoveryPropertiesRector extends AbstractRector
+{
+    private const array PROPERTY_RENAMES = [
+        'discoveryLocations' => 'locations',
+        'discoveryClasses' => 'classes',
+    ];
+
+    public function getNodeTypes(): array
+    {
+        return [
+            PropertyFetch::class,
+        ];
+    }
+
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node instanceof PropertyFetch) {
+            return null;
+        }
+
+        if (! $node->name instanceof Identifier) {
+            return null;
+        }
+
+        $propertyName = $node->name->toString();
+
+        if (! isset(self::PROPERTY_RENAMES[$propertyName])) {
+            return null;
+        }
+
+        if (! $this->isKernelType($node->var)) {
+            return null;
+        }
+
+        // Transform $kernel->discoveryLocations to $kernel->registry->locations
+        return new PropertyFetch(
+            new PropertyFetch($node->var, 'registry'),
+            self::PROPERTY_RENAMES[$propertyName],
+        );
+    }
+
+    private function isKernelType(Node\Expr $expr): bool
+    {
+        $type = $this->nodeTypeResolver->getType($expr);
+
+        foreach ($type->getObjectClassNames() as $className) {
+            if ($className === 'Tempest\Core\Kernel' || is_subclass_of($className, 'Tempest\Core\Kernel')) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+}

packages/upgrade/tests/Tempest34/Fixtures/KernelDiscoveryClasses.input.php

@@ -0,0 +1,15 @@
+<?php
+
+use Tempest\Core\Kernel;
+
+final class KernelDiscoveryClasses
+{
+    public function __construct(
+        private Kernel $kernel,
+    ) {}
+
+    public function getClasses(): array
+    {
+        return $this->kernel->discoveryClasses;
+    }
+}

packages/upgrade/tests/Tempest34/Fixtures/KernelDiscoveryLocations.input.php

@@ -0,0 +1,15 @@
+<?php
+
+use Tempest\Core\Kernel;
+
+final class KernelDiscoveryLocations
+{
+    public function __construct(
+        private Kernel $kernel,
+    ) {}
+
+    public function getLocations(): array
+    {
+        return $this->kernel->discoveryLocations;
+    }
+}

packages/upgrade/tests/Tempest34/Tempest34RectorTest.php

@@ -66,4 +66,20 @@ public function test_fully_qualified_discovery_cache(): void
             ->assertContains('Tempest\Discovery\DiscoveryCache')
             ->assertNotContains('Tempest\Core\DiscoveryCache');
     }
+
+    public function test_kernel_discovery_locations_refactored(): void
+    {
+        $this->rector
+            ->runFixture(__DIR__ . '/Fixtures/KernelDiscoveryLocations.input.php')
+            ->assertContains('$this->kernel->registry->locations')
+            ->assertNotContains('$this->kernel->discoveryLocations');
+    }
+
+    public function test_kernel_discovery_classes_refactored(): void
+    {
+        $this->rector
+            ->runFixture(__DIR__ . '/Fixtures/KernelDiscoveryClasses.input.php')
+            ->assertContains('$this->kernel->registry->classes')
+            ->assertNotContains('$this->kernel->discoveryClasses');
+    }
 }