wip

Author: xHeaven

packages/idempotency/src/Attributes/Idempotent.php

@@ -5,7 +5,9 @@
 namespace Tempest\Idempotency\Attributes;
 
 use Attribute;
+use Tempest\Idempotency\Exceptions\UnsupportedIdempotencyMethod;
 use Tempest\Idempotency\Middleware\IdempotencyMiddleware;
+use Tempest\Idempotency\SupportedMethod;
 use Tempest\Router\Route;
 use Tempest\Router\RouteDecorator;
 
@@ -21,6 +23,10 @@ public function __construct(
 
     public function decorate(Route $route): Route
     {
+        if (! SupportedMethod::isSupported($route->method)) {
+            throw UnsupportedIdempotencyMethod::forMethod($route->method);
+        }
+
         if (in_array(IdempotencyMiddleware::class, $route->middleware, true)) {
             return $route;
         }

packages/idempotency/src/Exceptions/UnsupportedIdempotencyMethod.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Idempotency\Exceptions;
+
+use RuntimeException;
+use Tempest\Http\Method;
+use Tempest\Idempotency\SupportedMethod;
+
+final class UnsupportedIdempotencyMethod extends RuntimeException
+{
+    public static function forMethod(Method $method): self
+    {
+        return new self(sprintf('Idempotency is only supported for %s methods, `%s` given.', SupportedMethod::allowed(), $method->value));
+    }
+}

packages/idempotency/src/Middleware/IdempotencyMiddleware.php

@@ -13,6 +13,7 @@
 use Tempest\Http\Status;
 use Tempest\Idempotency\Attributes\Idempotent;
 use Tempest\Idempotency\Config\IdempotencyConfig;
+use Tempest\Idempotency\Exceptions\UnsupportedIdempotencyMethod;
 use Tempest\Idempotency\Fingerprint\HttpFingerprintGenerator;
 use Tempest\Idempotency\Store\IdempotencyRecord;
 use Tempest\Idempotency\Store\IdempotencyState;
@@ -21,6 +22,7 @@
 use Tempest\Idempotency\Support\IdempotencyKeyResolver;
 use Tempest\Idempotency\Support\ProcessingOwner;
 use Tempest\Idempotency\Support\ProcessingOwnerLiveness;
+use Tempest\Idempotency\SupportedMethod;
 use Tempest\Router\HttpMiddleware;
 use Tempest\Router\HttpMiddlewareCallable;
 use Tempest\Router\MatchedRoute;
@@ -41,6 +43,10 @@ public function __construct(
 
     public function __invoke(Request $request, HttpMiddlewareCallable $next): Response
     {
+        if (! SupportedMethod::isSupported($request->method)) {
+            throw UnsupportedIdempotencyMethod::forMethod($request->method);
+        }
+
         $options = $this->resolveOptions();
         $key = trim($request->headers->get($options['header'], default: '') ?? '');
 

packages/idempotency/src/SupportedMethod.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Idempotency;
+
+use Tempest\Http\Method;
+
+enum SupportedMethod: string
+{
+    case POST = 'POST';
+    case PATCH = 'PATCH';
+
+    public static function isSupported(Method $method): bool
+    {
+        return self::tryFrom($method->value) !== null;
+    }
+
+    /** @return string */
+    public static function allowed(): string
+    {
+        return implode(', ', array_column(self::cases(), 'value'));
+    }
+}

packages/idempotency/tests/IdempotencyMiddlewareTest.php

@@ -20,6 +20,7 @@
 use Tempest\Http\Status;
 use Tempest\Idempotency\Attributes\Idempotent;
 use Tempest\Idempotency\Config\IdempotencyConfig;
+use Tempest\Idempotency\Exceptions\UnsupportedIdempotencyMethod;
 use Tempest\Idempotency\Fingerprint\RequestFingerprintGenerator;
 use Tempest\Idempotency\Middleware\IdempotencyMiddleware;
 use Tempest\Idempotency\Store\CacheIdempotencyStore;
@@ -129,7 +130,7 @@ public function rejects_the_same_key_when_the_payload_changes(): void
             $next,
         );
 
-        $this->assertSame(Status::CONFLICT, $secondResponse->status);
+        $this->assertSame(Status::UNPROCESSABLE_CONTENT, $secondResponse->status);
         $this->assertSame(1, $calls);
     }
 
@@ -241,6 +242,69 @@ public function idempotent_decorator_does_not_add_duplicate_middleware_entries()
         );
     }
 
+    #[Test]
+    public function idempotent_decorator_adds_middleware_for_patch_routes(): void
+    {
+        $route = new FakeRoute();
+        $route->method = Method::PATCH;
+        $attribute = new Idempotent();
+
+        $attribute->decorate($route);
+
+        $this->assertContains(IdempotencyMiddleware::class, $route->middleware);
+    }
+
+    #[Test]
+    public function idempotent_decorator_throws_for_get_routes(): void
+    {
+        $route = new FakeRoute();
+        $route->method = Method::GET;
+
+        $this->expectException(UnsupportedIdempotencyMethod::class);
+
+        new Idempotent()->decorate($route);
+    }
+
+    #[Test]
+    public function idempotent_decorator_throws_for_put_routes(): void
+    {
+        $route = new FakeRoute();
+        $route->method = Method::PUT;
+
+        $this->expectException(UnsupportedIdempotencyMethod::class);
+
+        new Idempotent()->decorate($route);
+    }
+
+    #[Test]
+    public function idempotent_decorator_throws_for_delete_routes(): void
+    {
+        $route = new FakeRoute();
+        $route->method = Method::DELETE;
+
+        $this->expectException(UnsupportedIdempotencyMethod::class);
+
+        new Idempotent()->decorate($route);
+    }
+
+    #[Test]
+    public function throws_for_non_post_and_patch_methods(): void
+    {
+        $middleware = $this->createMiddleware('create');
+
+        $this->expectException(UnsupportedIdempotencyMethod::class);
+
+        $middleware(
+            new GenericRequest(
+                Method::PUT,
+                '/orders',
+                body: ['amount' => 100],
+                headers: ['Idempotency-Key' => 'order-100'],
+            ),
+            new HttpMiddlewareCallable(static fn (Request $_): Response => new GenericResponse(Status::OK, ['ok' => true])),
+        );
+    }
+
     #[Test]
     public function uses_pending_ttl_for_lock_and_completion_ttl_for_pending_record(): void
     {