feat(database)!: allow setting char size (#2087)

Author: regnerisch

packages/database/src/QueryStatements/CharStatement.php

@@ -11,15 +11,17 @@
 {
     public function __construct(
         private string $name,
+        private int $size,
         private bool $nullable = false,
         private ?string $default = null,
     ) {}
 
     public function compile(DatabaseDialect $dialect): string
     {
         return sprintf(
-            '%s CHAR %s %s',
+            '%s CHAR(%s) %s %s',
             $dialect->quoteIdentifier($this->name),
+            $this->size,
             $this->default !== null ? "DEFAULT '{$this->default}'" : '',
             $this->nullable ? '' : 'NOT NULL',
         );

packages/database/src/QueryStatements/CreateTableStatement.php

@@ -186,10 +186,11 @@ public function string(string $name, int $length = 255, bool $nullable = false,
     /**
      * Adds a `CHAR` column to the table.
      */
-    public function char(string $name, bool $nullable = false, ?string $default = null): self
+    public function char(string $name, bool $nullable = false, ?string $default = null, int $size = 1): self
     {
         $this->statements[] = new CharStatement(
             name: $name,
+            size: $size,
             nullable: $nullable,
             default: $default,
         );

packages/database/tests/QueryStatements/CharStatementTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Tempest\Database\Tests\QueryStatements;
+
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+use Tempest\Database\Config\DatabaseDialect;
+use Tempest\Database\QueryStatements\CharStatement;
+
+final class CharStatementTest extends TestCase
+{
+    #[Test]
+    public function test_char(): void
+    {
+        $statement = new CharStatement(
+            name: 'foo',
+            size: 36,
+            nullable: false,
+            default: '019d38a9-5504-7a16-ab9d-520bbc289ecc',
+        );
+
+        $expectedMysql = '`foo` CHAR(36) DEFAULT \'019d38a9-5504-7a16-ab9d-520bbc289ecc\' NOT NULL';
+        $expectedPgsql = '"foo" CHAR(36) DEFAULT \'019d38a9-5504-7a16-ab9d-520bbc289ecc\' NOT NULL';
+
+        $this->assertSame($expectedMysql, $statement->compile(DatabaseDialect::MYSQL));
+        $this->assertSame($expectedPgsql, $statement->compile(DatabaseDialect::POSTGRESQL));
+    }
+}

tests/Integration/Database/QueryStatements/CreateTableStatementTest.php

@@ -34,7 +34,7 @@ public function up(): QueryStatement
             {
                 return new CreateTableStatement('test_table')
                     ->text('text', default: 'default')
-                    ->char('char', default: 'd')
+                    ->char('char', default: 'default', size: 7)
                     ->varchar('varchar', default: 'default')
                     ->float('float', default: 0.1)
                     ->integer('integer', default: 1)