-
-
Notifications
You must be signed in to change notification settings - Fork 176
feat(database): add integer type sizes #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4450dab
idea from #1972 integer in standard sql supports bigint (8 bytes), in…
DevPandi d07202f
Use self for IntegerBytes
DevPandi f9f24c6
Merge branch 'tempestphp:3.x' into 3.x
DevPandi 9676029
Remove unused test.
DevPandi 904c483
Merge remote-tracking branch 'origin/3.x' into 3.x
DevPandi 0fb2999
Merge branch '3.x' into 3.x
brendt 6fa720a
Rename IntegerBytes to DatabaseIntegerSize, Add union type.
DevPandi ca81961
Merge remote-tracking branch 'origin/3.x' into 3.x
DevPandi 35f7c51
Merge branch '3.x' into 3.x
DevPandi 37b8549
QA
brendt dba5251
Merge branch '3.x' into 3.x
brendt 1a020c1
Merge branch 'tempestphp:3.x' into 3.x
DevPandi a83931a
Fix error with union type.
DevPandi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Tempest\Database\QueryStatements; | ||
|
|
||
| enum IntegerBytes: int | ||
|
brendt marked this conversation as resolved.
Outdated
|
||
| { | ||
| case SMALL = 2; | ||
| case DEFAULT = 4; | ||
| case BIG = 8; | ||
|
|
||
| public static function fromBytes(int $bytes): self | ||
| { | ||
| return match (true) { | ||
| $bytes > self::DEFAULT->value => self::BIG, | ||
| $bytes > self::SMALL->value => self::DEFAULT, | ||
| DEFAULT => self::SMALL, | ||
| }; | ||
| } | ||
|
|
||
| public function toString(): string | ||
| { | ||
| return match($this) { | ||
| self::SMALL => 'SMALLINT', | ||
| self::DEFAULT => 'INTEGER', | ||
| self::BIG => 'BIGINT', | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.