Skip to content

fix(console): remove path check from completion script#2008

Merged
xHeaven merged 1 commit into
tempestphp:3.xfrom
xHeaven:completion
Mar 3, 2026
Merged

fix(console): remove path check from completion script#2008
xHeaven merged 1 commit into
tempestphp:3.xfrom
xHeaven:completion

Conversation

@xHeaven

@xHeaven xHeaven commented Feb 24, 2026

Copy link
Copy Markdown
Member

Composer generates a "Proxy PHP file" that breaks this check, therefore completion returns with empty list.

@xHeaven xHeaven requested a review from brendt as a code owner February 24, 2026 17:39
@github-actions

Copy link
Copy Markdown

Benchmark Results

Comparison of completion against 3.x (5563eac1332581f39b908f0e4b23adf53167c282).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
ViewRenderBench(benchPlainHtml) - 21.411mb 0.00% 348.887μs -6.57% ±1.89% -15.76%

Generated by phpbench against commit 503dba1

@xHeaven xHeaven changed the title fix(console): remove script path check fix(console): remove script path check from completion Feb 24, 2026
@xHeaven xHeaven changed the title fix(console): remove script path check from completion fix(console): remove path check from completion script Feb 24, 2026
@xHeaven xHeaven merged commit ead8ed6 into tempestphp:3.x Mar 3, 2026
83 of 84 checks passed
@xHeaven xHeaven deleted the completion branch March 3, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant