Skip to content

fix(router)!: return 404 when model binding fails#2014

Merged
innocenzi merged 4 commits into
tempestphp:3.xfrom
xHeaven:404
Mar 3, 2026
Merged

fix(router)!: return 404 when model binding fails#2014
innocenzi merged 4 commits into
tempestphp:3.xfrom
xHeaven:404

Conversation

@xHeaven

@xHeaven xHeaven commented Mar 3, 2026

Copy link
Copy Markdown
Member

This PR fixes Error 500 when a model binding fails. This change is kind of breaking, Rector upgrade is provided.

Fixes #2010.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

Benchmark Results

Comparison of 404 against 3.x (2e6d512efc0993d258f3c32b4fb8dfb1f05d866d).

Open to see the benchmark results

No benchmark changes above ±5%.

Generated by phpbench against commit 763153d

@innocenzi innocenzi merged commit e53ac47 into tempestphp:3.x Mar 3, 2026
82 checks passed
@xHeaven xHeaven deleted the 404 branch March 5, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Route Binding Does Not Return 404 HTTP Status

2 participants