Skip to content

Commit a961dcf

Browse files
committed
refined the comment for WorkflowExecutionOptions
1 parent 76e5a37 commit a961dcf

4 files changed

Lines changed: 25 additions & 17 deletions

File tree

openapi/openapiv2.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21005,7 +21005,7 @@
2100521005
},
2100621006
"timeSkippingConfig": {
2100721007
"$ref": "#/definitions/v1TimeSkippingConfig",
21008-
"description": "Time-skipping configuration for this workflow execution.\nIf not set, the time-skipping configuration is not updated by this request;\nthe existing configuration is preserved.\n\nWhen `fast_forward` is set, time will be fast-forwarded to a future point relative\nto the current workflow timestamp. Each call takes effect, even if\n`fast_forward` is set to the same duration, since the target time is recalculated\nfrom the current timestamp on every call."
21008+
"description": "The time-skipping configuration for this workflow execution.\nWhen `fast_forward` is set, time will be fast-forwarded to a future point relative\nto the current workflow timestamp. Each call takes effect, even if\n`fast_forward` is set to the same duration, since the target time is recalculated\nfrom the current timestamp on every call.\n\nThis field must be updated as a whole; updating individual sub-fields is not supported.\nWhen setting the update mask in `UpdateWorkflowExecutionOptionsRequest`, \n`BatchOperationUpdateWorkflowExecutionOptions`, etc., use a mask that covers the entire field."
2100921009
}
2101021010
}
2101121011
},
@@ -21042,7 +21042,11 @@
2104221042
},
2104321043
"timeSkippingConfig": {
2104421044
"$ref": "#/definitions/v1TimeSkippingConfig",
21045-
"description": "If set, the time-skipping configuration was changed. Contains the full updated configuration."
21045+
"description": "TimeSkippingConfig override upserted in this event. Represents the full config."
21046+
},
21047+
"timeSkippingConfigUpdated": {
21048+
"type": "boolean",
21049+
"description": "Indicates the time skipping config was updated by the recent call to update\nworkflow execution options."
2104621050
},
2104721051
"workflowUpdateOptions": {
2104821052
"type": "array",

openapi/openapiv3.yaml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19531,15 +19531,7 @@ components:
1953119531
timeSkippingConfig:
1953219532
allOf:
1953319533
- $ref: '#/components/schemas/TimeSkippingConfig'
19534-
description: |-
19535-
Time-skipping configuration for this workflow execution.
19536-
If not set, the time-skipping configuration is not updated by this request;
19537-
the existing configuration is preserved.
19538-
19539-
When `fast_forward` is set, time will be fast-forwarded to a future point relative
19540-
to the current workflow timestamp. Each call takes effect, even if
19541-
`fast_forward` is set to the same duration, since the target time is recalculated
19542-
from the current timestamp on every call.
19534+
description: "The time-skipping configuration for this workflow execution.\n When `fast_forward` is set, time will be fast-forwarded to a future point relative\n to the current workflow timestamp. Each call takes effect, even if\n `fast_forward` is set to the same duration, since the target time is recalculated\n from the current timestamp on every call.\n\n This field must be updated as a whole; updating individual sub-fields is not supported.\n When setting the update mask in `UpdateWorkflowExecutionOptionsRequest`, \n `BatchOperationUpdateWorkflowExecutionOptions`, etc., use a mask that covers the entire field."
1954319535
WorkflowExecutionOptionsUpdatedEventAttributes:
1954419536
type: object
1954519537
properties:
@@ -19574,7 +19566,12 @@ components:
1957419566
timeSkippingConfig:
1957519567
allOf:
1957619568
- $ref: '#/components/schemas/TimeSkippingConfig'
19577-
description: If set, the time-skipping configuration was changed. Contains the full updated configuration.
19569+
description: TimeSkippingConfig override upserted in this event. Represents the full config.
19570+
timeSkippingConfigUpdated:
19571+
type: boolean
19572+
description: |-
19573+
Indicates the time skipping config was updated by the recent call to update
19574+
workflow execution options.
1957819575
workflowUpdateOptions:
1957919576
type: array
1958019577
items:

temporal/api/history/v1/message.proto

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -915,8 +915,14 @@ message WorkflowExecutionOptionsUpdatedEventAttributes {
915915
// Priority override upserted in this event. Represents the full priority; not just partial fields.
916916
// Ignored if nil.
917917
temporal.api.common.v1.Priority priority = 6;
918-
// If set, the time-skipping configuration was changed. Contains the full updated configuration.
918+
919+
// TimeSkippingConfig override upserted in this event. Represents the full config.
919920
temporal.api.common.v1.TimeSkippingConfig time_skipping_config = 7;
921+
922+
// Indicates the time skipping config was updated by the recent call to update
923+
// workflow execution options.
924+
bool time_skipping_config_updated = 9;
925+
920926
// Updates to workflow updates options.
921927
repeated WorkflowUpdateOptionsUpdate workflow_update_options = 8;
922928
}

temporal/api/workflow/v1/message.proto

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -585,14 +585,15 @@ message WorkflowExecutionOptions {
585585
// If set, overrides the workflow's priority sent by the SDK.
586586
temporal.api.common.v1.Priority priority = 2;
587587

588-
// Time-skipping configuration for this workflow execution.
589-
// If not set, the time-skipping configuration is not updated by this request;
590-
// the existing configuration is preserved.
591-
//
588+
// The time-skipping configuration for this workflow execution.
592589
// When `fast_forward` is set, time will be fast-forwarded to a future point relative
593590
// to the current workflow timestamp. Each call takes effect, even if
594591
// `fast_forward` is set to the same duration, since the target time is recalculated
595592
// from the current timestamp on every call.
593+
//
594+
// This field must be updated as a whole; updating individual sub-fields is not supported.
595+
// When setting the update mask in `UpdateWorkflowExecutionOptionsRequest`,
596+
// `BatchOperationUpdateWorkflowExecutionOptions`, etc., use a mask that covers the entire field.
596597
temporal.api.common.v1.TimeSkippingConfig time_skipping_config = 3;
597598
}
598599

0 commit comments

Comments
 (0)