Nexus samples: use business IDs for workflow IDs#137
Open
VegetarianOrc wants to merge 2 commits intomainfrom
Open
Nexus samples: use business IDs for workflow IDs#137VegetarianOrc wants to merge 2 commits intomainfrom
VegetarianOrc wants to merge 2 commits intomainfrom
Conversation
chrsmith
reviewed
Apr 28, 2026
| new() { Id = GetHelloWorkflowId(input) })); | ||
|
|
||
| private static string GetHelloWorkflowId(IHelloService.HelloInput input) => | ||
| $"hello-{input.Language}-{input.Name.Trim().Replace(' ', '-')}"; |
There was a problem hiding this comment.
The other examples, e.g. temporalio/samples-go#460, aren't going through the Name.Trim().Replace(...) jazz.
Are spaces allowed in Workflow IDs? If they are, then maybe that would just be overkill for the sample, if that type of sanitization isn't required? (Or if it is, maybe it should be added to the other examples?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Stop using the Nexus request ID as the backing workflow ID. Build a meaningful business ID from the operation input.
Why?
Our samples should reflect best practices around creating meaningful IDs. Part of temporalio/features#692.