AWS Lambda#721
Conversation
| fresh Temporal client and worker, runs until the Lambda deadline minus `ShutdownDeadlineBuffer`, then shuts down and runs | ||
| configured shutdown hooks. | ||
|
|
||
| ## Configuration |
There was a problem hiding this comment.
how do I configure the shutdown timing?
jmaeagle99
left a comment
jmaeagle99
left a comment
There was a problem hiding this comment.
Wanted to provide some feedback; still reviewing.
eamsden
force-pushed
the
ea/aws-lambda
branch
3 times, most recently
from
ac825bb to
c916b4d
Compare
jmaeagle99
left a comment
jmaeagle99
left a comment
There was a problem hiding this comment.
Some more feedback. I think once these are addressed, this PR will be in good shape to merge.
and tuning enforcement
- Formatting - Documentation - WaitAsync polyfill
jmaeagle99
left a comment
jmaeagle99
left a comment
There was a problem hiding this comment.
Just a few more, but approving.
|
|
||
| - Fixed `ClientEnvConfig` empty `OverrideEnvVars` handling so an explicit empty dictionary no | ||
| longer falls back to process environment variables. | ||
| ### Breaking Changes |
There was a problem hiding this comment.
Neither of these changes are accurate. All of this code is new so it cannot be breaking nor changed. There should be one entry in Added that describes the creation of these Lambda support packages.
There was a problem hiding this comment.
I missed that the AI had updated that. 😳
| <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" /> | ||
| <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" /> | ||
| <PackageVersion Include="NexusRpc" Version="0.3.0" /> | ||
| <PackageVersion Include="OpenTelemetry" Version="1.15.3" /> |
There was a problem hiding this comment.
Can you add the new OpenTelemetry.* packages to the ignore group in https://github.com/temporalio/sdk-dotnet/blob/main/.github/dependabot.yml#L68 so that way we don't get constantly pestered to update but still get security updates.
| /// Gets or sets the client configuration loader. | ||
| /// </summary> | ||
| public Func<ClientEnvConfig.ProfileLoadOptions?, TemporalClientConnectOptions>? LoadClientConnectOptions | ||
| { get; set; } |
There was a problem hiding this comment.
Sorry, I could have been more clear. It's the { get; set; } being on its own line that looks strange.
3 participants
What was changed
Add helpers for serverless workers running on AWS Lambda
Why?
SDKs require specific helpers to run effectively on AWS Lambda.
Checklist
Closes
How was this tested:
Code in a separate PR in samples-dotnet ( Lambda Worker Sample samples-dotnet#152 ) was used to test deploying and running workflows and activities on a Lambda worker.
Any docs updates needed?