Renamed methods to remove the word signal

Author: Evanthx

temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java

@@ -139,7 +139,7 @@ public WorkflowSignalOutput signal(WorkflowSignalInput input) {
     // Server >=1.31 with EnableCHASMSignalBacklinks returns a backlink pointing at the signal
     // event; older servers leave it unset. Propagate when present.
     if (CurrentNexusOperationContext.isNexusContext() && response.hasLink()) {
-      CurrentNexusOperationContext.get().addSignalWorkflowResponseLink(response.getLink());
+      CurrentNexusOperationContext.get().addBacklink(response.getLink());
     }
     return new WorkflowSignalOutput();
   }
@@ -178,7 +178,7 @@ public WorkflowSignalWithStartOutput signalWithStart(WorkflowSignalWithStartInpu
     // Server >=1.31 with EnableCHASMSignalBacklinks returns a backlink pointing at the signal
     // event; older servers leave it unset. Propagate when present.
     if (CurrentNexusOperationContext.isNexusContext() && response.hasSignalLink()) {
-      CurrentNexusOperationContext.get().addSignalWorkflowResponseLink(response.getSignalLink());
+      CurrentNexusOperationContext.get().addBacklink(response.getSignalLink());
     }
     // TODO currently SignalWithStartWorkflowExecutionResponse doesn't have eagerWorkflowTask.
     //  We should wire it when it's implemented server-side.

temporal-sdk/src/main/java/io/temporal/internal/nexus/InternalNexusOperationContext.java

@@ -22,17 +22,16 @@ public class InternalNexusOperationContext {
   // workflow client (signal, signalWithStart) can attach them to outgoing requests via
   // SignalWorkflowExecutionRequest.links.
   private List<Link> nexusOperationLinks = Collections.emptyList();
-  // Backlinks returned by SignalWorkflowExecutionResponse.link /
-  // SignalWithStartWorkflowExecutionResponse.signal_link. One entry per signal RPC issued from
-  // within the Nexus operation handler. Drained by the task handler when building
-  // StartOperationResponse so every signal the handler issues gets a corresponding link on the
-  // caller workflow's history event.
+  // Backlinks returned by outbound RPCs the operation handler issues (currently
+  // SignalWorkflowExecutionResponse.link and SignalWithStartWorkflowExecutionResponse.signal_link;
+  // future update/start variants attach the same way). One entry per outbound RPC that returned
+  // a link. Drained by the task handler when building StartOperationResponse so each RPC the
+  // handler issued gets a corresponding link on the caller workflow's history event.
   //
   // NOTE: this context is only safe for use from the single thread that runs the operation
   // handler (the Nexus task executor's thread). Handlers that spawn their own threads to issue
-  // signals will not see the thread-local context, so the links from those signals will not
-  // propagate.
-  private final List<Link> signalWorkflowResponseLinks = new ArrayList<>();
+  // RPCs will not see the thread-local context, so the links from those RPCs will not propagate.
+  private final List<Link> responseBacklinks = new ArrayList<>();
 
   public InternalNexusOperationContext(
       String namespace,
@@ -88,7 +87,7 @@ public Link getStartWorkflowResponseLink() {
 
   /**
    * Set the {@code common.v1.Link}s extracted from the inbound Nexus task so they can be attached
-   * to any signal RPCs issued by the operation handler.
+   * to RPCs issued by the operation handler.
    */
   public void setNexusOperationLinks(List<Link> links) {
     this.nexusOperationLinks = links == null ? Collections.emptyList() : links;
@@ -100,19 +99,19 @@ public List<Link> getNexusOperationLinks() {
   }
 
   /**
-   * Append a backlink returned by a signal-class RPC (signal or signalWithStart). Each signal the
-   * operation handler issues should add one entry; the task handler drains the list when building
-   * the operation's StartOperationResponse.
+   * Append a backlink returned by an outbound RPC the operation handler issued (e.g. signal,
+   * signalWithStart, and future update/start variants). The task handler drains the list when
+   * building the operation's StartOperationResponse.
    */
-  public void addSignalWorkflowResponseLink(Link link) {
+  public void addBacklink(Link link) {
     if (link != null) {
-      this.signalWorkflowResponseLinks.add(link);
+      this.responseBacklinks.add(link);
     }
   }
 
-  /** Backlinks from every signal RPC issued by the handler. Never null; may be empty. */
-  public List<Link> getSignalWorkflowResponseLinks() {
-    return signalWorkflowResponseLinks;
+  /** Backlinks from every outbound RPC the handler issued. Never null; may be empty. */
+  public List<Link> getBacklinks() {
+    return responseBacklinks;
   }
 
   private class NexusOperationContextImpl implements NexusOperationContext {

temporal-sdk/src/main/java/io/temporal/internal/nexus/NexusTaskHandlerImpl.java

@@ -328,27 +328,28 @@ private StartOperationResponse handleStartOperation(
       try {
         OperationStartResult<HandlerResultContent> result =
             startOperation(context, operationStartDetails.build(), input.build());
-        // If signal/signalWithStart RPCs issued by the handler returned backlinks, propagate
-        // them to the caller so the caller workflow's history event links to each signal event
-        // on the callee. Same set of backlinks applies to both sync and async response variants.
-        List<io.temporal.api.nexus.v1.Link> signalBacklinks = new ArrayList<>();
-        for (io.temporal.api.common.v1.Link signalResponseLink :
-            CurrentNexusOperationContext.get().getSignalWorkflowResponseLinks()) {
-          if (!signalResponseLink.hasWorkflowEvent()) {
+        // If outbound RPCs the handler issued (signal, signalWithStart, future update/start
+        // variants) returned backlinks, propagate them to the caller so the caller workflow's
+        // history event links to each event on the callee. Same set of backlinks applies to both
+        // sync and async response variants.
+        List<io.temporal.api.nexus.v1.Link> backlinks = new ArrayList<>();
+        for (io.temporal.api.common.v1.Link backlink :
+            CurrentNexusOperationContext.get().getBacklinks()) {
+          if (!backlink.hasWorkflowEvent()) {
             continue;
           }
           io.temporal.api.nexus.v1.Link converted =
-              LinkConverter.workflowEventToNexusLink(signalResponseLink.getWorkflowEvent());
+              LinkConverter.workflowEventToNexusLink(backlink.getWorkflowEvent());
           if (converted != null) {
-            signalBacklinks.add(converted);
+            backlinks.add(converted);
           }
         }
 
         if (result.isSync()) {
           startResponseBuilder.setSyncSuccess(
               StartOperationResponse.Sync.newBuilder()
                   .setPayload(Payload.parseFrom(result.getSyncResult().getDataBytes()))
-                  .addAllLinks(signalBacklinks)
+                  .addAllLinks(backlinks)
                   .build());
         } else {
           startResponseBuilder.setAsyncSuccess(
@@ -364,7 +365,7 @@ private StartOperationResponse handleStartOperation(
                                       .setUrl(link.getUri().toString())
                                       .build())
                           .collect(Collectors.toList()))
-                  .addAllLinks(signalBacklinks)
+                  .addAllLinks(backlinks)
                   .build());
         }
       } catch (OperationException e) {