address comments, change signatures to newer

Author: mavemuri

temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java

@@ -521,9 +521,8 @@ private <R> UpdateWorkflowExecutionRequest toUpdateWorkflowExecutionRequest(
                     .setIdentity(clientOptions.getIdentity()))
             .setInput(updateInput);
 
-    // If this update is being issued from inside a Nexus operation handler via
-    // TemporalNexusClientImpl.startWorkflowUpdate, set the fields the server needs
-    // to deliver the Nexus completion callback.
+    // If this update is being issued via TemporalNexusClientImpl.startWorkflowUpdate,
+    // set the fields the server needs to deliver the Nexus completion callback
     if (CurrentNexusOperationContext.isNexusContext()) {
       InternalNexusOperationContext nexusContext = CurrentNexusOperationContext.get();
       // already in a Nexus operation context, dont need to check nexusContext again
@@ -549,10 +548,9 @@ private <R> UpdateWorkflowExecutionRequest toUpdateWorkflowExecutionRequest(
                     nexusOperationMetadata.operationToken,
                     requestLinks))
             .addAllLinks(requestLinks);
-      } else {
-        log.error("unexpected error fetching nexusOperationMetadata");
-        // maybe throw an exception but should never really happen as its all sdk
       }
+      // If no NexusOperationMetadata was found, but there is a NexusContext, then the
+      // update was likely trigger via Operation handler directly
     }
 
     Request request = requestBuilder.build();

temporal-sdk/src/main/java/io/temporal/internal/common/LinkConverter.java

@@ -107,7 +107,7 @@ public static io.temporal.api.nexus.v1.Link workflowLinkToNexusLink(Link.Workflo
           .setUrl(url)
           .setType(workflowLinkType)
           .build();
-    } catch (UnsupportedEncodingException e) {
+    } catch (Exception e) {
       log.error("Failed to encode Nexus link URL", e);
       return null;
     }
@@ -190,6 +190,7 @@ public static Link nexusLinkToWorkflowLink(io.temporal.api.nexus.v1.Link nexusLi
     Link.Builder link = Link.newBuilder();
     try {
       URI uri = new URI(nexusLink.getUrl());
+      log.debug("Parsing nexus link URL: {}", uri.getRawPath());
       if (!uri.getScheme().equals(temporalUrlScheme)) {
         log.error("Failed to parse Nexus link URL: invalid scheme: {}", uri.getScheme());
         return null;
@@ -234,7 +235,6 @@ public static io.temporal.api.nexus.v1.Link linkToNexusLink(Link commonLink) {
     if (commonLink.hasNexusOperation()) {
       return nexusOperationToNexusLink(commonLink.getNexusOperation());
     }
-    // check for workflow link only if a more specific variant is not set
     if (commonLink.hasWorkflow()) {
       return workflowLinkToNexusLink(commonLink.getWorkflow());
     }

…/CancelUpdateWorkflowExecutionInput.java …ral/nexus/CancelUpdateWorkflowInput.javatemporal-sdk/src/main/java/io/temporal/nexus/CancelUpdateWorkflowExecutionInput.java renamed to temporal-sdk/src/main/java/io/temporal/nexus/CancelUpdateWorkflowInput.java temporal-sdk/src/main/java/io/temporal/nexus/CancelUpdateWorkflowExecutionInput.java renamed to temporal-sdk/src/main/java/io/temporal/nexus/CancelUpdateWorkflowInput.java

@@ -1,24 +1,23 @@
 package io.temporal.nexus;
 
+import com.google.common.base.Strings;
 import io.temporal.common.Experimental;
 import java.util.Objects;
-import javax.annotation.Nullable;
 
 /**
  * Input to {@link TemporalOperationHandler#cancelUpdateWorkflow} describing the workflow update to
  * cancel.
  */
 @Experimental
-public final class CancelUpdateWorkflowExecutionInput {
+public final class CancelUpdateWorkflowInput {
 
   private final String workflowId;
-  @Nullable private final String runId;
+  private final String runId;
   private final String updateId;
 
-  public CancelUpdateWorkflowExecutionInput(
-      String workflowId, @Nullable String runId, String updateId) {
+  public CancelUpdateWorkflowInput(String workflowId, String runId, String updateId) {
     this.workflowId = Objects.requireNonNull(workflowId);
-    this.runId = runId;
+    this.runId = Strings.nullToEmpty(runId);
     this.updateId = Objects.requireNonNull(updateId);
   }
 
@@ -27,8 +26,7 @@ public String getWorkflowId() {
     return workflowId;
   }
 
-  /** Returns the run ID extracted from the operation token, or null if not present. */
-  @Nullable
+  /** Returns the run ID extracted from the operation token, or empty if not present. */
   public String getRunId() {
     return runId;
   }