Spring boot: fail creation if duplicate definitions detected (#2511)

Author: Quinn-With-Two-Ns

temporal-spring-boot-autoconfigure/src/main/java/io/temporal/spring/boot/autoconfigure/properties/NamespaceProperties.java

@@ -15,17 +15,21 @@ public class NamespaceProperties {
   private final @Nullable List<WorkerProperties> workers;
   private final @Nonnull String namespace;
   private final @Nullable WorkflowCacheProperties workflowCache;
+  private final @Nullable Boolean ignoreDuplicateDefinitions;
 
   @ConstructorBinding
   public NamespaceProperties(
       @Nullable String namespace,
       @Nullable WorkersAutoDiscoveryProperties workersAutoDiscovery,
       @Nullable List<WorkerProperties> workers,
-      @Nullable WorkflowCacheProperties workflowCache) {
+      @Nullable WorkflowCacheProperties workflowCache,
+      @Nullable Boolean ignoreDuplicateDefinitions) {
     this.workersAutoDiscovery = workersAutoDiscovery;
     this.workers = workers;
     this.namespace = MoreObjects.firstNonNull(namespace, NAMESPACE_DEFAULT);
     this.workflowCache = workflowCache;
+    this.ignoreDuplicateDefinitions =
+        MoreObjects.firstNonNull(ignoreDuplicateDefinitions, Boolean.TRUE);
   }
 
   @Nullable
@@ -51,6 +55,11 @@ public WorkflowCacheProperties getWorkflowCache() {
     return workflowCache;
   }
 
+  @Nonnull
+  public Boolean isIgnoreDuplicateDefinitions() {
+    return Boolean.TRUE;
+  }
+
   public static class WorkflowCacheProperties {
     private final @Nullable Integer maxInstances;
     private final @Nullable Integer maxThreads;

temporal-spring-boot-autoconfigure/src/main/java/io/temporal/spring/boot/autoconfigure/properties/NonRootNamespaceProperties.java

@@ -43,8 +43,9 @@ public NonRootNamespaceProperties(
       @Nullable List<WorkerProperties> workers,
       @Nullable WorkflowCacheProperties workflowCache,
       @Nullable ConnectionProperties connection,
-      @Nullable Boolean startWorkers) {
-    super(namespace, workersAutoDiscovery, workers, workflowCache);
+      @Nullable Boolean startWorkers,
+      @Nullable Boolean ignoreDuplicateDefinitions) {
+    super(namespace, workersAutoDiscovery, workers, workflowCache, ignoreDuplicateDefinitions);
     this.alias = alias;
     this.connection = connection;
     this.startWorkers = startWorkers;

temporal-spring-boot-autoconfigure/src/main/java/io/temporal/spring/boot/autoconfigure/properties/TemporalProperties.java

@@ -24,8 +24,9 @@ public TemporalProperties(
       @Nullable WorkflowCacheProperties workflowCache,
       @Nonnull ConnectionProperties connection,
       @Nullable TestServerProperties testServer,
-      @Nullable Boolean startWorkers) {
-    super(namespace, workersAutoDiscovery, workers, workflowCache);
+      @Nullable Boolean startWorkers,
+      @Nullable Boolean ignoreDuplicateDefinitions) {
+    super(namespace, workersAutoDiscovery, workers, workflowCache, ignoreDuplicateDefinitions);
     this.connection = connection;
     this.testServer = testServer;
     this.startWorkers = startWorkers;

temporal-spring-boot-autoconfigure/src/main/java/io/temporal/spring/boot/autoconfigure/template/WorkersTemplate.java

@@ -432,6 +432,9 @@ private void configureActivityImplementationAutoDiscovery(
             worker.getTaskQueue(),
             registeredEx.getRegisteredTypeName());
       }
+      if (!namespaceProperties.isIgnoreDuplicateDefinitions()) {
+        throw registeredEx;
+      }
     }
   }
 
@@ -468,6 +471,9 @@ private void configureNexusServiceImplementationAutoDiscovery(
             worker.getTaskQueue(),
             registeredEx.getRegisteredTypeName());
       }
+      if (!namespaceProperties.isIgnoreDuplicateDefinitions()) {
+        throw registeredEx;
+      }
     }
   }
 
@@ -492,6 +498,9 @@ private void configureWorkflowImplementationAutoDiscovery(
             worker.getTaskQueue(),
             registeredEx.getRegisteredTypeName());
       }
+      if (!namespaceProperties.isIgnoreDuplicateDefinitions()) {
+        throw registeredEx;
+      }
     }
   }