Skip to content

Commit 4ffa0cd

Browse files
committed
Don't run the tests against the in-memory server as it doesn't support SANO yet
1 parent ec9e103 commit 4ffa0cd

4 files changed

Lines changed: 12 additions & 28 deletions

File tree

temporal-sdk/src/test/java/io/temporal/client/nexus/NexusAsyncApiTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.temporal.client.nexus;
22

3-
import static org.junit.Assume.assumeTrue;
4-
53
import io.temporal.api.nexus.v1.Endpoint;
64
import io.temporal.client.NexusClient;
75
import io.temporal.client.NexusClientOptions;
@@ -14,6 +12,7 @@
1412
import io.temporal.client.UntypedNexusServiceClient;
1513
import io.temporal.testing.internal.SDKTestWorkflowRule;
1614
import io.temporal.workflow.shared.EchoNexusServiceImpl;
15+
import io.temporal.workflow.shared.StandaloneNexusTestPrerequisites;
1716
import io.temporal.workflow.shared.TestNexusServices;
1817
import io.temporal.workflow.shared.TestWorkflows;
1918
import java.time.Duration;
@@ -44,11 +43,8 @@ public class NexusAsyncApiTest {
4443
.build();
4544

4645
@BeforeClass
47-
public static void requireExternalService() {
48-
// The time-skipping test server does not implement standalone Nexus operation RPCs.
49-
assumeTrue(
50-
"standalone Nexus operations require a real server",
51-
SDKTestWorkflowRule.useExternalService);
46+
public static void requireServerWithStandaloneNexusSupport() {
47+
StandaloneNexusTestPrerequisites.requireServerSupport();
5248
}
5349

5450
// --- NexusServiceClient.executeAsync ---

temporal-sdk/src/test/java/io/temporal/client/nexus/NexusClientTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.temporal.client.nexus;
22

3-
import static org.junit.Assume.assumeTrue;
4-
53
import io.temporal.api.nexus.v1.Endpoint;
64
import io.temporal.client.NexusClient;
75
import io.temporal.client.NexusOperationExecutionCount;
@@ -11,6 +9,7 @@
119
import io.temporal.client.UntypedNexusServiceClient;
1210
import io.temporal.testing.internal.SDKTestWorkflowRule;
1311
import io.temporal.workflow.shared.EchoNexusServiceImpl;
12+
import io.temporal.workflow.shared.StandaloneNexusTestPrerequisites;
1413
import io.temporal.workflow.shared.TestNexusServices;
1514
import io.temporal.workflow.shared.TestWorkflows;
1615
import java.time.Duration;
@@ -33,11 +32,8 @@ public class NexusClientTest {
3332
.build();
3433

3534
@BeforeClass
36-
public static void requireExternalService() {
37-
// The time-skipping test server does not implement standalone Nexus operation RPCs.
38-
assumeTrue(
39-
"standalone Nexus operations require a real server",
40-
SDKTestWorkflowRule.useExternalService);
35+
public static void requireServerWithStandaloneNexusSupport() {
36+
StandaloneNexusTestPrerequisites.requireServerSupport();
4137
}
4238

4339
@Test

temporal-sdk/src/test/java/io/temporal/client/nexus/NexusOperationHandleTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.temporal.client.nexus;
22

3-
import static org.junit.Assume.assumeTrue;
4-
53
import io.temporal.api.enums.v1.NexusOperationExecutionStatus;
64
import io.temporal.api.nexus.v1.Endpoint;
75
import io.temporal.client.NexusClient;
@@ -15,6 +13,7 @@
1513
import io.temporal.client.UntypedNexusServiceClient;
1614
import io.temporal.testing.internal.SDKTestWorkflowRule;
1715
import io.temporal.workflow.shared.EchoNexusServiceImpl;
16+
import io.temporal.workflow.shared.StandaloneNexusTestPrerequisites;
1817
import io.temporal.workflow.shared.TestNexusServices;
1918
import io.temporal.workflow.shared.TestWorkflows;
2019
import java.time.Duration;
@@ -39,11 +38,8 @@ public class NexusOperationHandleTest {
3938
.build();
4039

4140
@BeforeClass
42-
public static void requireExternalService() {
43-
// The time-skipping test server does not implement standalone Nexus operation RPCs.
44-
assumeTrue(
45-
"standalone Nexus operations require a real server",
46-
SDKTestWorkflowRule.useExternalService);
41+
public static void requireServerWithStandaloneNexusSupport() {
42+
StandaloneNexusTestPrerequisites.requireServerSupport();
4743
}
4844

4945
@Test

temporal-sdk/src/test/java/io/temporal/client/nexus/NexusServiceClientTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.temporal.client.nexus;
22

3-
import static org.junit.Assume.assumeTrue;
4-
53
import io.temporal.api.nexus.v1.Endpoint;
64
import io.temporal.client.NexusClientOptions;
75
import io.temporal.client.NexusOperationExecutionDescription;
@@ -11,6 +9,7 @@
119
import io.temporal.client.UntypedNexusOperationHandle;
1210
import io.temporal.testing.internal.SDKTestWorkflowRule;
1311
import io.temporal.workflow.shared.EchoNexusServiceImpl;
12+
import io.temporal.workflow.shared.StandaloneNexusTestPrerequisites;
1413
import io.temporal.workflow.shared.TestNexusServices;
1514
import io.temporal.workflow.shared.TestWorkflows;
1615
import java.time.Duration;
@@ -34,11 +33,8 @@ public class NexusServiceClientTest {
3433
.build();
3534

3635
@BeforeClass
37-
public static void requireExternalService() {
38-
// The time-skipping test server does not implement standalone Nexus operation RPCs.
39-
assumeTrue(
40-
"standalone Nexus operations require a real server",
41-
SDKTestWorkflowRule.useExternalService);
36+
public static void requireServerWithStandaloneNexusSupport() {
37+
StandaloneNexusTestPrerequisites.requireServerSupport();
4238
}
4339

4440
@Test

0 commit comments

Comments
 (0)