You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add note about Rosetta for old protoc-gen-rpc-java (#2815)
I tripped over newer MacOS not installing Rosetta by default when we
were silently relying on that to cover for the version of
protoc-gen-rpc-java not shipping MacOS aarch64 binaries. I'm adding a
note to CONTRIBUTING.md and comments in the relevant gradle files so
other developers have some hope of not falling down the same rabbit hole
I did.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+17Lines changed: 17 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -60,3 +60,20 @@ Build with:
60
60
```bash
61
61
./gradlew build
62
62
```
63
+
64
+
## Note on Rosetta
65
+
Newer Apple Silicon macs do not ship with Rosetta by default, and the version of `protoc-gen-rpc-java` we use (1.34.1) does not ship Apple Silicon binaries.
66
+
67
+
So Gradle is set to hardcode the download of the x86_64 binaries on MacOS, but this depends on Rosetta to function. Make sure Rosetta is installed with
68
+
69
+
```bash
70
+
/usr/bin/pgrep oahd
71
+
```
72
+
73
+
which should return a PID of the Rosetta process. If it doesn't, you'll need to run
0 commit comments