Code review

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/nexus/NexusStartWorkflowHelper.java

@@ -16,7 +16,8 @@
 
 /**
  * Shared helper for starting a workflow from a Nexus operation and attaching workflow links to the
- * operation context. Used by both {@code WorkflowRunOperationImpl} and {@code TemporalNexusClient}.
+ * operation context. Used by both {@code WorkflowRunOperationImpl} and {@code
+ * TemporalNexusClientImpl}.
  */
 public class NexusStartWorkflowHelper {
 

temporal-sdk/src/main/java/io/temporal/nexus/TemporalNexusClientImpl.java

@@ -5,12 +5,14 @@
 import io.temporal.client.WorkflowClient;
 import io.temporal.client.WorkflowOptions;
 import io.temporal.client.WorkflowStub;
+import io.temporal.common.Experimental;
 import io.temporal.internal.client.NexusStartWorkflowResponse;
 import io.temporal.internal.nexus.NexusStartWorkflowHelper;
 import io.temporal.workflow.Functions;
 import java.util.Objects;
 
 /** Package-private implementation of {@link TemporalNexusClient}. */
+@Experimental
 final class TemporalNexusClientImpl implements TemporalNexusClient {
 
   private final WorkflowClient client;

temporal-sdk/src/main/java/io/temporal/nexus/TemporalOperationHandler.java

@@ -18,13 +18,13 @@
  *
  * <pre>{@code
  * @OperationImpl
- * public OperationHandler<OrderInput, OrderResult> createOrder() {
+ * public OperationHandler<TransferInput, TransferResult> startTransfer() {
  *   return TemporalOperationHandler.from((context, client, input) -> {
  *     return client.startWorkflow(
- *         OrderWorkflow.class,
- *         wf -> wf.processOrder(input),
+ *         TransferWorkflow.class,
+ *         TransferWorkflow::transfer, input.getFromAccount(), input.getToAccount(),
  *         WorkflowOptions.newBuilder()
- *             .setWorkflowId("order-" + input.getOrderId())
+ *             .setWorkflowId("transfer-" + input.getTransferId())
  *             .build());
  *   });
  * }
@@ -70,7 +70,7 @@ public static <T, R> TemporalOperationHandler<T, R> from(StartFunction<T, R> sta
   }
 
   @Override
-  public OperationStartResult<R> start(
+  public final OperationStartResult<R> start(
       OperationContext ctx, OperationStartDetails details, T input) {
     InternalNexusOperationContext nexusCtx = CurrentNexusOperationContext.get();
     TemporalNexusClient client =
@@ -91,7 +91,7 @@ public OperationStartResult<R> start(
   }
 
   @Override
-  public void cancel(OperationContext ctx, OperationCancelDetails details) {
+  public final void cancel(OperationContext ctx, OperationCancelDetails details) {
     OperationToken token;
     try {
       token = OperationTokenUtil.loadOperationToken(details.getOperationToken());