Add @TemporalOperation annotation for Nexus operations #2928
Draft
Quinn-With-Two-Ns wants to merge 3 commits into
Draft
Add @TemporalOperation annotation for Nexus operations #2928Quinn-With-Two-Ns wants to merge 3 commits into
Quinn-With-Two-Ns wants to merge 3 commits into
Conversation
Quinn-With-Two-Ns
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Introduces
@TemporalOperation, a method-level annotation that declares a Temporal-backed Nexus operation directly on a@ServiceImplclass. The framework wraps the annotated method as the start handler with default cancel behavior, removing the boilerplate of a separate TemporalOperationHandler for the common workflow-run case.@OperationImplis still supported for custom cancel or handler composition, and both annotations can coexist on the same service (but not the same method).Why?
Make it easier to define Nexus Operation Handlers by having less boilerplate between the interface and the implementation
Checklist
Closes
How was this tested:
Note requires nexus-rpc/sdk-java#46 to be merged