Add ChildWorkflow id test (#617)

Author: roxblnfk

src/Workflow/WorkflowExecution.php

@@ -22,6 +22,7 @@
 class WorkflowExecution
 {
     /**
+     * @var non-empty-string
      * @psalm-readonly
      * @psalm-allow-private-mutation
      */
@@ -30,6 +31,7 @@ class WorkflowExecution
     private string $id;
 
     /**
+     * @var non-empty-string|null
      * @psalm-readonly
      * @psalm-allow-private-mutation
      */
@@ -43,11 +45,17 @@ public function __construct(?string $id = null, ?string $runId = null)
         $this->runId = $runId;
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function getID(): string
     {
         return $this->id;
     }
 
+    /**
+     * @return non-empty-string|null
+     */
     public function getRunID(): ?string
     {
         return $this->runId;

tests/Acceptance/Extra/Workflow/ChildWorkflowIdTest.php

@@ -0,0 +1,88 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Temporal\Tests\Acceptance\Extra\Workflow\ChildWorkflowId;
+
+use PHPUnit\Framework\Attributes\CoversFunction;
+use PHPUnit\Framework\Attributes\Test;
+use Temporal\Client\WorkflowClientInterface;
+use Temporal\Client\WorkflowStubInterface;
+use Temporal\Tests\Acceptance\App\Attribute\Stub;
+use Temporal\Tests\Acceptance\App\TestCase;
+use Temporal\Workflow;
+use Temporal\Workflow\WorkflowInterface;
+use Temporal\Workflow\WorkflowMethod;
+
+#[CoversFunction('Temporal\Internal\Workflow\Process\Process::logRunningHandlers')]
+class ChildWorkflowIdTest extends TestCase
+{
+    #[Test]
+    public function updateHandlersWithOneCall(
+        #[Stub('Extra_Workflow_ChildWorkflowId', args: [true])] WorkflowStubInterface $stub,
+        WorkflowClientInterface $client,
+    ): void {
+        $deadline = \microtime(true) + 5.0; // 5-second timeout
+        do {
+            $childId = $stub->query('getChildId')->getValue(0);
+            if ($childId !== null) {
+                break;
+            }
+        } while (\microtime(true) < $deadline);
+
+        $childId ?? $this->fail('Child workflow not started.');
+
+        // Get child workflow stub
+        $child = $client->newRunningWorkflowStub(TestWorkflow::class, $childId);
+
+        $this->assertSame($stub->getExecution()->getID(), $child->getParentId());
+    }
+}
+
+#[WorkflowInterface]
+class TestWorkflow
+{
+    /** @var non-empty-string|null */
+    private ?string $childId = null;
+
+    private bool $exit = false;
+
+    #[WorkflowMethod(name: "Extra_Workflow_ChildWorkflowId")]
+    public function handle(bool $createChild = false)
+    {
+        // Start a child workflow and store its ID
+        if ($createChild) {
+            $child = Workflow::newUntypedChildWorkflowStub("Extra_Workflow_ChildWorkflowId");
+            $result = yield $child->start(false);
+            $this->childId = $result->getID();
+        }
+
+        yield Workflow::await(
+            fn(): bool => $this->exit,
+        );
+    }
+
+    /**
+     * @return null|non-empty-string
+     */
+    #[Workflow\QueryMethod]
+    public function getChildId(): ?string
+    {
+        return $this->childId;
+    }
+
+    /**
+     * @return null|non-empty-string
+     */
+    #[Workflow\QueryMethod]
+    public function getParentId(): ?string
+    {
+        return Workflow::getInfo()->parentExecution?->getID();
+    }
+
+    #[Workflow\SignalMethod]
+    public function exit(): void
+    {
+        $this->exit = true;
+    }
+}