Don't set empty metadata dto in proto.

Author: roxblnfk

psalm-baseline.xml

@@ -442,19 +442,11 @@
     <MissingTemplateParam>
       <code><![CDATA[$fails]]></code>
     </MissingTemplateParam>
-    <PossiblyNullArgument>
-      <code><![CDATA[$options->retryOptions ? $options->retryOptions->toWorkflowRetryPolicy() : null]]></code>
-      <code><![CDATA[$options->toMemo($this->converter)]]></code>
-      <code><![CDATA[$options->toSearchAttributes($this->converter)]]></code>
-    </PossiblyNullArgument>
     <PossiblyNullReference>
       <code><![CDATA[getName]]></code>
       <code><![CDATA[getStartWorkflow]]></code>
       <code><![CDATA[getUpdateWorkflow]]></code>
     </PossiblyNullReference>
-    <RedundantConditionGivenDocblockType>
-      <code><![CDATA[$delay !== null]]></code>
-    </RedundantConditionGivenDocblockType>
     <UndefinedInterfaceMethod>
       <code><![CDATA[toHeader]]></code>
     </UndefinedInterfaceMethod>
@@ -878,6 +870,9 @@
       <code><![CDATA[self::FORMAT_MONTHS]]></code>
       <code><![CDATA[self::FORMAT_YEARS]]></code>
     </DeprecatedConstant>
+    <RedundantCondition>
+      <code><![CDATA[$nullEmpty && $seconds === 0 && $micros === 0]]></code>
+    </RedundantCondition>
   </file>
   <file src="src/Internal/Support/DateTime.php">
     <InvalidReturnStatement>

src/Client/WorkflowOptions.php

@@ -517,7 +517,7 @@ public function withStaticDetails(string $details): self
      */
     public function toMemo(DataConverterInterface $converter): ?Memo
     {
-        if ($this->memo === null) {
+        if ($this->memo === null || $this->memo === []) {
             return null;
         }
 

src/Internal/Client/WorkflowStarter.php

@@ -316,14 +316,6 @@ private function configureExecutionRequest(
         StartInput $input,
     ): StartWorkflowExecutionRequest|SignalWithStartWorkflowExecutionRequest {
         $options = $input->options;
-        $header = $input->header;
-
-        \assert($header instanceof Header);
-        $header->setDataConverter($this->converter);
-
-        $metadata = (new UserMetadata())
-            ->setSummary($this->converter->toPayload($options->staticSummary))
-            ->setDetails($this->converter->toPayload($options->staticDetails));
 
         $req->setRequestId(Uuid::v4())
             ->setIdentity($this->clientOptions->identity)
@@ -332,22 +324,43 @@ private function configureExecutionRequest(
             ->setWorkflowType(new WorkflowType(['name' => $input->workflowType]))
             ->setWorkflowId($input->workflowId)
             ->setCronSchedule($options->cronSchedule ?? '')
-            ->setRetryPolicy($options->retryOptions ? $options->retryOptions->toWorkflowRetryPolicy() : null)
             ->setWorkflowIdReusePolicy($options->workflowIdReusePolicy)
             ->setWorkflowIdConflictPolicy($options->workflowIdConflictPolicy->value)
             ->setWorkflowRunTimeout(DateInterval::toDuration($options->workflowRunTimeout))
             ->setWorkflowExecutionTimeout(DateInterval::toDuration($options->workflowExecutionTimeout))
-            ->setWorkflowTaskTimeout(DateInterval::toDuration($options->workflowTaskTimeout))
-            ->setMemo($options->toMemo($this->converter))
-            ->setSearchAttributes($options->toSearchAttributes($this->converter))
-            ->setHeader($header->toHeader())
-            ->setUserMetadata($metadata);
-
-        $delay = DateInterval::toDuration($options->workflowStartDelay);
-        if ($delay !== null && ($delay->getSeconds() > 0 || $delay->getNanos() > 0)) {
-            $req->setWorkflowStartDelay($delay);
+            ->setWorkflowTaskTimeout(DateInterval::toDuration($options->workflowTaskTimeout));
+
+        // Retry Policy
+        $options->retryOptions === null or $req->setRetryPolicy($options->retryOptions->toWorkflowRetryPolicy());
+
+        // Memo
+        $memo = $options->toMemo($this->converter);
+        $memo === null or $req->setMemo($memo);
+
+        // Search Attributes
+        $searchAttributes = $options->toSearchAttributes($this->converter);
+        $searchAttributes === null or $req->setSearchAttributes($searchAttributes);
+
+        // Header
+        $header = $input->header;
+        \assert($header instanceof Header);
+        if ($header->count() > 0) {
+            $header->setDataConverter($this->converter);
+            $req->setHeader($header->toHeader());
         }
 
+        // User metadata
+        if ($options->staticSummary !== '' || $options->staticDetails !== '') {
+            $metadata = (new UserMetadata());
+            $options->staticSummary === '' or $metadata->setSummary($this->converter->toPayload($options->staticSummary));
+            $options->staticDetails === '' or $metadata->setDetails($this->converter->toPayload($options->staticDetails));
+            $req->setUserMetadata($metadata);
+        }
+
+        // Start Delay
+        $delay = DateInterval::toDuration($options->workflowStartDelay, true);
+        $delay === null or $req->setWorkflowStartDelay($delay);
+
         if ($req instanceof StartWorkflowExecutionRequest) {
             $req->setRequestEagerExecution($options->eagerStart);
         }

src/Internal/Support/DateInterval.php

@@ -17,6 +17,7 @@
 /**
  * @psalm-type DateIntervalFormat = DateInterval::FORMAT_*
  * @psalm-type DateIntervalValue = string | int | float | \DateInterval | Duration | null
+ * @internal
  */
 final class DateInterval
 {
@@ -148,20 +149,25 @@ public static function assert($interval): bool
     }
 
     /**
-     * @return ($i is null ? null : Duration)
+     * @param bool $nullEmpty return null if the interval is empty
+     *
+     * @return ($i is null ? null : ($nullEmpty is true ? Duration|null : Duration))
      */
-    public static function toDuration(?\DateInterval $i = null): ?Duration
+    public static function toDuration(?\DateInterval $i = null, bool $nullEmpty = false): ?Duration
     {
         if ($i === null) {
             return null;
         }
 
-        $d = new Duration();
         $parsed = self::parse($i);
-        $d->setSeconds((int) $parsed->totalSeconds);
-        $d->setNanos($parsed->microseconds * 1000);
-
-        return $d;
+        $seconds = (int) $parsed->totalSeconds;
+        $micros = $parsed->microseconds;
+
+        return $nullEmpty && $seconds === 0 && $micros === 0
+            ? null
+            : (new Duration())
+                ->setSeconds((int) $parsed->totalSeconds)
+                ->setNanos($parsed->microseconds * 1000);
     }
 
     private static function validateFormat(string $format): void