test: remove unused TemporalStarter dependency from DeploymentTest causing temporal server reboot (#730)

Author: xepozz

testing/src/Environment.php

@@ -256,6 +256,9 @@ public function executeTemporalCommand(array|string $command, int $timeout = 10)
 
         $process = new Process($command);
         $process->setTimeout($timeout);
+
+        $this->io->info('Executing Temporal Command: ' . $this->serializeProcess($process));
+
         $process->run();
     }
 
@@ -304,7 +307,7 @@ public function isTemporalTestRunning(): bool
         return $this->temporalTestServerProcess?->isRunning() === true;
     }
 
-    private function serializeProcess(?Process $temporalServerProcess): string|array
+    private function serializeProcess(?Process $temporalServerProcess): string
     {
         $reflection = new \ReflectionClass($temporalServerProcess);
         $reflectionProperty = $reflection->getProperty('commandline');

tests/Acceptance/Extra/Versioning/DeploymentTest.php

@@ -30,14 +30,12 @@ class DeploymentTest extends TestCase
     public function defaultBehaviorAuto(
         Environment $environment,
         RRStarter $roadRunnerStarter,
-        TemporalStarter $starter,
         WorkflowClientInterface $client,
         Feature $feature,
     ): void {
         $behavior = self::executeWorkflow(
             $environment,
             $roadRunnerStarter,
-            $starter,
             $client,
             $feature,
             /** @see DefaultWorkflow */
@@ -51,15 +49,13 @@ public function defaultBehaviorAuto(
     public function customBehaviorPinned(
         Environment $environment,
         RRStarter $roadRunnerStarter,
-        TemporalStarter $starter,
         WorkflowClientInterface $client,
         Feature $feature,
     ): void {
         $id = Uuid::v4();
         self::executeWorkflow(
             $environment,
             $roadRunnerStarter,
-            $starter,
             $client,
             $feature,
             /** @see PinnedWorkflow */
@@ -86,15 +82,13 @@ public function customBehaviorPinned(
     public function versionBehaviorOverrideAutoUpgrade(
         Environment $environment,
         RRStarter $roadRunnerStarter,
-        TemporalStarter $starter,
         WorkflowClientInterface $client,
         Feature $feature,
     ): void {
         $id = Uuid::v4();
         self::executeWorkflow(
             $environment,
             $roadRunnerStarter,
-            $starter,
             $client,
             $feature,
             /** @see PinnedWorkflow */
@@ -121,14 +115,12 @@ public function versionBehaviorOverrideAutoUpgrade(
     public function versionBehaviorOverridePinned(
         Environment $environment,
         RRStarter $roadRunnerStarter,
-        TemporalStarter $starter,
         WorkflowClientInterface $client,
         Feature $feature,
     ): void {
         $behavior = self::executeWorkflow(
             $environment,
             $roadRunnerStarter,
-            $starter,
             $client,
             $feature,
             /** @see PinnedWorkflow */
@@ -151,7 +143,6 @@ public function versionBehaviorOverridePinned(
     private static function executeWorkflow(
         Environment $environment,
         RRStarter $roadRunnerStarter,
-        TemporalStarter $temporalStarter,
         WorkflowClientInterface $client,
         Feature $feature,
         string $workflowType,
@@ -200,8 +191,7 @@ private static function executeWorkflow(
             $postAction === null or $postAction($behavior);
             return $behavior;
         } finally {
-            $temporalStarter->stop();
-            $temporalStarter->start();
+            $roadRunnerStarter->stop();
             $roadRunnerStarter->start();
         }
     }