refactor(Request): Just use microtime for start id

Author: roxblnfk

src/Worker/Transport/Command/Client/Request.php

@@ -18,6 +18,8 @@
 use Temporal\Worker\Transport\Command\Common\RequestTrait;
 use Temporal\Worker\Transport\Command\RequestInterface;
 
+\define(['REQUEST_START_ID'][0], (int) (\microtime(true) * 1_000_000.0));
+
 /**
  * Carries request to perform host action with payloads and failure as context. Can be cancelled if allows
  *
@@ -27,7 +29,7 @@ class Request implements RequestInterface
 {
     use RequestTrait;
 
-    protected static int $lastID = 9000;
+    protected static int $lastID = REQUEST_START_ID;
     protected int $id;
     protected ValuesInterface $payloads;
     protected HeaderInterface $header;
@@ -63,9 +65,14 @@ public function getFailure(): ?\Throwable
         return $this->failure;
     }
 
-    protected function getNextID(): int
+    private function getNextID(): int
     {
-        static::$lastID = (static::$lastID + 1) % 1_000_000;
-        return \time() * 1_000_000 + static::$lastID;
+        ++static::$lastID;
+
+        if (static::$lastID === \PHP_INT_MAX) {
+            static::$lastID = 1;
+        }
+
+        return static::$lastID;
     }
 }

tests/Fixtures/CommandResetter.php

@@ -19,15 +19,4 @@ public static function reset(): void
     {
         self::$lastID = 9000;
     }
-
-    protected function getNextID(): int
-    {
-        $next = ++static::$lastID;
-
-        if ($next >= \PHP_INT_MAX) {
-            $next = static::$lastID = 1;
-        }
-
-        return $next;
-    }
 }