refactor: streamline RRStarter initialization by embedding allowed test classes directly in State, remove unused method parameter

Author: xepozz

tests/Acceptance/App/Runtime/RRStarter.php

@@ -11,6 +11,7 @@
 final class RRStarter
 {
     private Environment $environment;
+
     public function __construct(
         private State $runtime,
         ?Environment $environment = null,
@@ -19,15 +20,14 @@ public function __construct(
         \register_shutdown_function(fn() => $this->stop());
     }
 
-    /**
-     * @param list<class-string> $allowedTestClasses
-     */
-    public function start(array $allowedTestClasses = []): void
+    public function start(): void
     {
         if ($this->environment->isRoadRunnerRunning()) {
             return;
         }
 
+        $allowedTestClasses = $this->runtime->allowedTestClasses;
+
         $systemInfo = SystemInfo::detect();
         $run = $this->runtime->command;
 

tests/Acceptance/App/Runtime/State.php

@@ -18,6 +18,13 @@ final class State
     /** @var non-empty-string */
     public string $address;
 
+    /**
+     * @var list<class-string> Test classes the worker pool was bootstrapped with.
+     *   Honored by RRStarter on initial start AND on every restart, so failure-triggered
+     *   restarts preserve the same selection instead of falling back to "register all".
+     */
+    public array $allowedTestClasses = [];
+
     /**
      * @param non-empty-string $rrConfigDir Dir with rr.yaml
      * @param non-empty-string $workDir Dir where tests are run

tests/Acceptance/App/RuntimeBuilder.php

@@ -73,6 +73,7 @@ public static function createState(
         array $allowedTestClasses = [],
     ): State {
         $runtime = new State($command, \dirname(__DIR__), $workDir, $testCasesDir, $workers);
+        $runtime->allowedTestClasses = $allowedTestClasses;
 
         self::hydrateClasses($runtime, $allowedTestClasses);
 

tests/Acceptance/ExecutionStartedSubscriber.php

@@ -57,7 +57,10 @@ public function notify(ExecutionStarted $event): void
         }
 
         $logger = new StderrLogger();
-        $logger->info('[selection] picked test classes after filtering', ['count' => \count($selectedTestClasses)]);
+        $logger->info('[selection] picked test classes after filtering', [
+            'count' => \count($selectedTestClasses),
+            'classes' => $selectedTestClasses,
+        ]);
 
         RuntimeBuilder::init();
 
@@ -95,7 +98,7 @@ public function notify(ExecutionStarted $event): void
         $temporalRunner = new TemporalStarter($environment);
         $rrRunner = new RRStarter($state, $environment);
         $temporalRunner->start();
-        $rrRunner->start($selectedTestClasses);
+        $rrRunner->start();
 
         $serviceClient = $state->command->tlsKey === null && $state->command->tlsCert === null
             ? ServiceClient::create($state->address)