Skip to content

Commit e60c9e3

Browse files
authored
Merge pull request #615: Null coalesce in AttributeMapper instead of try/catch
1 parent b9b9d13 commit e60c9e3

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

src/Internal/Marshaller/Mapper/AttributeMapper.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,7 @@ private function detectType(\ReflectionProperty $property, ?MarshallingRule &$ru
134134
private function createGetter(string $name, ?TypeInterface $type): \Closure
135135
{
136136
return function () use ($name, $type) {
137-
try {
138-
$result = $this->$name;
139-
} catch (\Error $_) {
140-
return null;
141-
}
137+
$result = $this->$name ?? null;
142138

143139
return $type && $result !== null ? $type->serialize($result) : $result;
144140
};
@@ -147,11 +143,7 @@ private function createGetter(string $name, ?TypeInterface $type): \Closure
147143
private function createSetter(string $name, ?TypeInterface $type): \Closure
148144
{
149145
return function ($value) use ($name, $type): void {
150-
try {
151-
$source = $this->$name;
152-
} catch (\Error $_) {
153-
$source = null;
154-
}
146+
$source = $this->$name ?? null;
155147

156148
$this->$name = $type ? $type->parse($value, $source) : $value;
157149
};

0 commit comments

Comments
 (0)