handle missing auth case for register_files

Author: JasonSteving99

temporalio/contrib/google_gemini_sdk/_gemini_activity.py

@@ -130,8 +130,15 @@ async def gemini_files_register(
             Token refresh happens here on the worker side, so no auth
             material enters the workflow event history.
             """
+            auth = self._credentials or self._client._api_client._credentials
+            if auth is None:
+                raise ValueError(
+                    "No credentials available for register_files(). "
+                    "Pass extra_credentials to GeminiPlugin or initialize "
+                    "the genai.Client with credentials."
+                )
             return await self._client.aio.files.register_files(
-                auth=self._credentials or self._client._api_client._credentials,
+                auth=auth,
                 uris=req.uris,
                 config=req.config,
             )

temporalio/contrib/google_gemini_sdk/_temporal_files.py

@@ -11,9 +11,10 @@
 import io
 import os
 from datetime import timedelta
-from typing import Optional, Union
+from typing import TYPE_CHECKING, Optional, Union
 
-import google.auth.credentials
+if TYPE_CHECKING:
+    import google.auth.credentials
 from google.genai import types
 from google.genai.files import AsyncFiles
 from google.genai.types import HttpOptions

tests/contrib/google_gemini_sdk/test_gemini.py

@@ -257,7 +257,7 @@ def apply_plugin(
 
     tracker = GeminiApiCallTracker(mock_responses)
     original_activities = GeminiApiCaller.activities
-    GeminiApiCaller.activities = lambda self: [
+    GeminiApiCaller.activities = lambda self: [  # type: ignore[method-assign]
         tracker.gemini_api_client_async_request,
         tracker.gemini_api_client_async_request_streamed,
         tracker.gemini_files_upload,
@@ -268,7 +268,7 @@ def apply_plugin(
         gemini = GeminiClient(api_key="fake-test-key")
         plugin = GeminiPlugin(gemini)
     finally:
-        GeminiApiCaller.activities = original_activities
+        GeminiApiCaller.activities = original_activities  # type: ignore[method-assign]
 
     config = client.config()
     config["plugins"] = [plugin]
@@ -598,6 +598,24 @@ async def run(self, store_name: str, file_path: str) -> str:
         return op.name or ""
 
 
+@workflow.defn
+class RegisterFilesWorkflow:
+    """Workflow that calls files.register_files."""
+
+    @workflow.run
+    async def run(self, uris: list[str]) -> str:
+        client = gemini_client()
+        # auth arg is ignored by TemporalAsyncFiles — the activity uses
+        # credentials from GeminiPlugin init.  We pass a dummy here;
+        # can't import google.auth.credentials in the sandbox so we
+        # use a sentinel that satisfies the type at runtime.
+        resp = await client.files.register_files(
+            auth=None,  # type: ignore[arg-type]
+            uris=uris,
+        )
+        return str(len(resp.files or []))
+
+
 @workflow.defn
 class ChatWorkflow:
     """Workflow that uses client.chats for multi-turn conversation."""
@@ -1095,15 +1113,15 @@ async def _gen():
 
     # Mock file operations at the high-level SDK interface (these are what
     # the real activities call).
-    gemini.aio.files.upload = AsyncMock(
+    gemini.aio.files.upload = AsyncMock(  # type: ignore[method-assign]
         return_value=types.File(
             name="files/mock-uploaded",
             uri="https://fake.uri/files/mock-uploaded",
             size_bytes=42,
         )
     )
-    gemini.aio.files.download = AsyncMock(return_value=b"mock download content")
-    gemini.aio.file_search_stores.upload_to_file_search_store = AsyncMock(
+    gemini.aio.files.download = AsyncMock(return_value=b"mock download content")  # type: ignore[method-assign]
+    gemini.aio.file_search_stores.upload_to_file_search_store = AsyncMock(  # type: ignore[method-assign]
         return_value=types.UploadToFileSearchStoreOperation.model_construct(
             name="operations/mock-op"
         )
@@ -1155,6 +1173,34 @@ async def test_full_integration_with_mock_client(client: Client):
     assert result["store_deleted"] is True
 
 
+async def test_register_files_without_credentials_fails(client: Client):
+    """register_files raises when no credentials are available."""
+    # _apply_plugin_with_mock_client uses api_key auth with no
+    # extra_credentials, so the activity should raise ValueError.
+    new_client = _apply_plugin_with_mock_client(client, [])
+
+    async with new_worker(new_client, RegisterFilesWorkflow) as worker:
+        with pytest.raises(WorkflowFailureError) as exc_info:
+            await new_client.execute_workflow(
+                RegisterFilesWorkflow.run,
+                ["gs://bucket/file.txt"],
+                id=f"gemini-register-no-creds-{uuid.uuid4()}",
+                task_queue=worker.task_queue,
+                execution_timeout=timedelta(seconds=10),
+            )
+
+    # The error is nested: WorkflowFailureError → ActivityError → ApplicationError
+    cause: BaseException | None = exc_info.value.cause
+    while (
+        cause is not None
+        and hasattr(cause, "__cause__")
+        and cause.__cause__ is not None
+    ):
+        cause = cause.__cause__
+    assert cause is not None
+    assert "No credentials available for register_files" in str(cause)
+
+
 # ===========================================================================
 # TemporalAsyncClient wiring tests
 # ===========================================================================