Skip to content

Commit 2cfe041

Browse files
committed
Remove unused rpc_metadata/rpc_timeout from child interceptor inputs
Remove rpc_metadata and rpc_timeout fields from UpdateWithStartUpdateWorkflowInput and UpdateWithStartStartWorkflowInput. These fields were never forwarded to the underlying execute_multi_operation gRPC call — only the top-level StartWorkflowUpdateWithStartInput fields are authoritative. Also remove the corresponding parameters from WithStartWorkflowOperation since they only served to populate the (now-removed) child input fields. This is a breaking change for interceptors that accessed rpc_metadata or rpc_timeout on the child input objects.
1 parent c70d68c commit 2cfe041

3 files changed

Lines changed: 3 additions & 24 deletions

File tree

temporalio/client/_client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,8 +1190,6 @@ async def _start_update_with_start(
11901190
args=temporalio.common._arg_or_args(arg, args),
11911191
headers={},
11921192
ret_type=result_type or result_type_from_type_hint,
1193-
rpc_metadata=rpc_metadata,
1194-
rpc_timeout=rpc_timeout,
11951193
wait_for_stage=wait_for_stage,
11961194
)
11971195

temporalio/client/_interceptor.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,6 @@ class UpdateWithStartUpdateWorkflowInput:
334334
wait_for_stage: WorkflowUpdateStage
335335
headers: Mapping[str, temporalio.api.common.v1.Payload]
336336
ret_type: type | None
337-
rpc_metadata: Mapping[str, str | bytes]
338-
rpc_timeout: timedelta | None
339337

340338

341339
@dataclass
@@ -366,8 +364,6 @@ class UpdateWithStartStartWorkflowInput:
366364
static_details: str | None
367365
# Type may be absent
368366
ret_type: type | None
369-
rpc_metadata: Mapping[str, str | bytes]
370-
rpc_timeout: timedelta | None
371367
priority: temporalio.common.Priority
372368
versioning_override: temporalio.common.VersioningOverride | None = None
373369

@@ -376,12 +372,9 @@ class UpdateWithStartStartWorkflowInput:
376372
class StartWorkflowUpdateWithStartInput:
377373
"""Input for :py:meth:`OutboundInterceptor.start_update_with_start_workflow`.
378374
379-
The top-level ``rpc_metadata`` and ``rpc_timeout`` fields are authoritative
380-
for the ``execute_multi_operation`` gRPC call. The sub-inputs
381-
(``start_workflow_input`` and ``update_workflow_input``) also carry their own
382-
``rpc_metadata`` / ``rpc_timeout`` for interceptor introspection, but those
383-
values are **not** forwarded to the gRPC call. Interceptors that wish to set
384-
RPC metadata should modify :py:attr:`rpc_metadata` on this object.
375+
The ``rpc_metadata`` and ``rpc_timeout`` fields are authoritative for the
376+
``execute_multi_operation`` gRPC call. Interceptors that wish to set RPC
377+
metadata should modify :py:attr:`rpc_metadata` on this object.
385378
"""
386379

387380
start_workflow_input: UpdateWithStartStartWorkflowInput

temporalio/client/_workflow.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,8 +1065,6 @@ def __init__(
10651065
static_summary: str | None = None,
10661066
static_details: str | None = None,
10671067
start_delay: timedelta | None = None,
1068-
rpc_metadata: Mapping[str, str | bytes] = {},
1069-
rpc_timeout: timedelta | None = None,
10701068
priority: temporalio.common.Priority = temporalio.common.Priority.default,
10711069
versioning_override: temporalio.common.VersioningOverride | None = None,
10721070
) -> None: ...
@@ -1095,8 +1093,6 @@ def __init__(
10951093
static_summary: str | None = None,
10961094
static_details: str | None = None,
10971095
start_delay: timedelta | None = None,
1098-
rpc_metadata: Mapping[str, str | bytes] = {},
1099-
rpc_timeout: timedelta | None = None,
11001096
priority: temporalio.common.Priority = temporalio.common.Priority.default,
11011097
versioning_override: temporalio.common.VersioningOverride | None = None,
11021098
) -> None: ...
@@ -1127,8 +1123,6 @@ def __init__(
11271123
static_summary: str | None = None,
11281124
static_details: str | None = None,
11291125
start_delay: timedelta | None = None,
1130-
rpc_metadata: Mapping[str, str | bytes] = {},
1131-
rpc_timeout: timedelta | None = None,
11321126
priority: temporalio.common.Priority = temporalio.common.Priority.default,
11331127
versioning_override: temporalio.common.VersioningOverride | None = None,
11341128
) -> None: ...
@@ -1159,8 +1153,6 @@ def __init__(
11591153
static_summary: str | None = None,
11601154
static_details: str | None = None,
11611155
start_delay: timedelta | None = None,
1162-
rpc_metadata: Mapping[str, str | bytes] = {},
1163-
rpc_timeout: timedelta | None = None,
11641156
priority: temporalio.common.Priority = temporalio.common.Priority.default,
11651157
versioning_override: temporalio.common.VersioningOverride | None = None,
11661158
) -> None: ...
@@ -1189,8 +1181,6 @@ def __init__(
11891181
static_summary: str | None = None,
11901182
static_details: str | None = None,
11911183
start_delay: timedelta | None = None,
1192-
rpc_metadata: Mapping[str, str | bytes] = {},
1193-
rpc_timeout: timedelta | None = None,
11941184
priority: temporalio.common.Priority = temporalio.common.Priority.default,
11951185
versioning_override: temporalio.common.VersioningOverride | None = None,
11961186
stack_level: int = 2,
@@ -1228,8 +1218,6 @@ def __init__(
12281218
start_delay=start_delay,
12291219
headers={},
12301220
ret_type=result_type or result_type_from_run_fn,
1231-
rpc_metadata=rpc_metadata,
1232-
rpc_timeout=rpc_timeout,
12331221
priority=priority,
12341222
versioning_override=versioning_override,
12351223
)

0 commit comments

Comments
 (0)