Harden release smoke package install

Author: tconley1428

.github/actions/release-smoke-package/action.yml

@@ -7,8 +7,8 @@ inputs:
   index-url:
     description: "Primary package index URL"
     required: true
-  extra-index-url:
-    description: "Optional fallback package index URL"
+  dependency-index-url:
+    description: "Optional dependency package index URL"
     required: false
     default: ""
 runs:
@@ -22,18 +22,18 @@ runs:
       env:
         VERSION: ${{ inputs.version }}
         INDEX_URL: ${{ inputs.index-url }}
-        EXTRA_INDEX_URL: ${{ inputs.extra-index-url }}
+        DEPENDENCY_INDEX_URL: ${{ inputs.dependency-index-url }}
       run: |
         set -euo pipefail
         python -m venv .venv
         .venv/bin/python -m pip install --upgrade pip
 
-        install_args=(--prefer-binary --index-url "$INDEX_URL")
-        if [[ -n "$EXTRA_INDEX_URL" ]]; then
-          install_args+=(--extra-index-url "$EXTRA_INDEX_URL")
+        install_args=(--version "$VERSION" --index-url "$INDEX_URL")
+        if [[ -n "$DEPENDENCY_INDEX_URL" ]]; then
+          install_args+=(--dependency-index-url "$DEPENDENCY_INDEX_URL")
         fi
 
-        .venv/bin/python -m pip install "${install_args[@]}" "temporalio==$VERSION"
+        .venv/bin/python .github/scripts/install_release_package.py "${install_args[@]}"
     - name: Run SDK smoke test
       shell: bash
       env:

.github/scripts/install_release_package.py

@@ -0,0 +1,54 @@
+"""Install a release package for smoke testing."""
+
+from __future__ import annotations
+
+import argparse
+import importlib.metadata
+import subprocess
+import sys
+from collections.abc import Sequence
+
+
+def _pip_install(args: Sequence[str]) -> None:
+    subprocess.check_call([sys.executable, "-m", "pip", "install", *args])
+
+
+def install_package(args: argparse.Namespace) -> None:
+    package = f"temporalio=={args.version}"
+    if args.dependency_index_url:
+        _pip_install(
+            [
+                "--prefer-binary",
+                "--index-url",
+                args.index_url,
+                "--no-deps",
+                package,
+            ]
+        )
+
+        requirements = importlib.metadata.requires("temporalio") or []
+        if requirements:
+            _pip_install(
+                [
+                    "--prefer-binary",
+                    "--index-url",
+                    args.dependency_index_url,
+                    *requirements,
+                ]
+            )
+    else:
+        _pip_install(["--prefer-binary", "--index-url", args.index_url, package])
+
+    subprocess.check_call([sys.executable, "-m", "pip", "check"])
+
+
+def main(argv: Sequence[str] | None = None) -> None:
+    parser = argparse.ArgumentParser()
+    parser.add_argument("--version", required=True)
+    parser.add_argument("--index-url", required=True)
+    parser.add_argument("--dependency-index-url")
+    install_package(parser.parse_args(argv))
+
+
+if __name__ == "__main__":
+    main()

.github/workflows/release-publish.yml

@@ -2,12 +2,6 @@ name: Release Publish
 run-name: Release from main
 
 on:
-  pull_request:
-    paths:
-      - ".github/actions/release-smoke-package/action.yml"
-      - ".github/scripts/release_smoke_package.py"
-      - ".github/scripts/release_verify.py"
-      - ".github/workflows/release-publish.yml"
   workflow_dispatch:
 
 permissions:
@@ -196,7 +190,7 @@ jobs:
         with:
           version: ${{ needs.verify_artifacts.outputs.version }}
           index-url: https://test.pypi.org/simple/
-          extra-index-url: https://pypi.org/simple/
+          dependency-index-url: https://pypi.org/simple/
 
   publish_pypi:
     name: Publish to PyPI