Skip to content

Expose Last Completion Result and Previous Run Failure#1067

Merged
tconley1428 merged 8 commits into
mainfrom
last_completion_result
Sep 4, 2025
Merged

Expose Last Completion Result and Previous Run Failure#1067
tconley1428 merged 8 commits into
mainfrom
last_completion_result

Conversation

@tconley1428

@tconley1428 tconley1428 commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

What was changed

Title

Why?

Users request access to this information, it is available in Go, Java and TS.

Checklist

  1. Closes [Feature Request] Provide last result and last failure to workflows #383

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner August 29, 2025 16:32
@cretz

cretz commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #383

I think we also need last failure (unless it's in another PR), and while last completion may only be for scheduled workflows/cron, last failure is also for others like retry.

@tconley1428 tconley1428 changed the title Expose Last Completion Result inside a scheduled workflow Expose Last Completion Result and Previous Run Failure Sep 2, 2025
cretz
cretz reviewed Sep 2, 2025
View reviewed changes
Comment thread temporalio/workflow.py Outdated
dandavison
dandavison reviewed Sep 3, 2025
View reviewed changes
Comment thread temporalio/worker/_workflow_instance.py
dandavison
dandavison reviewed Sep 4, 2025
View reviewed changes
Comment thread temporalio/workflow.py Outdated
dandavison
dandavison reviewed Sep 4, 2025
View reviewed changes
Comment thread temporalio/worker/_workflow.py Outdated
dandavison
dandavison reviewed Sep 4, 2025
View reviewed changes
Comment thread temporalio/workflow.py
dandavison
dandavison reviewed Sep 4, 2025
View reviewed changes
Comment thread temporalio/workflow.py Outdated
dandavison
dandavison reviewed Sep 4, 2025
View reviewed changes

@dandavison dandavison left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Of the suggestions I made I am hoping that a non-empty subset (the docstring ones) will be the cause of further changes to the PR before merge.

cretz
cretz approved these changes Sep 4, 2025
View reviewed changes

@cretz cretz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking from my POV

Comment thread temporalio/worker/_workflow.py Outdated
@tconley1428 tconley1428 merged commit 44412ae into main Sep 4, 2025
27 of 28 checks passed
@tconley1428 tconley1428 deleted the last_completion_result branch September 4, 2025 16:38
@chris-olszewski chris-olszewski mentioned this pull request Oct 14, 2025
Merged
@yakupt-canonical yakupt-canonical mentioned this pull request Oct 20, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dandavison dandavison dandavison left review comments
+1 more reviewer
@cretz cretz cretz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Provide last result and last failure to workflows

3 participants

@tconley1428 @cretz @dandavison