System Nexus payload handling from WIT#1572
Open
tconley1428 wants to merge 16 commits into
Open
Conversation
df8f660 to
cd4dd9b
Compare
tconley1428
commented
Jun 9, 2026
tconley1428
commented
Jun 9, 2026
tconley1428
commented
Jun 9, 2026
tconley1428
commented
Jun 9, 2026
tconley1428
commented
Jun 9, 2026
Member
|
Guide on how to review this would be good |
Contributor
Author
|
@Sushisource reviewing in person with @THardy98 and @dplyukhin |
THardy98
reviewed
Jun 11, 2026
THardy98
reviewed
Jun 11, 2026
THardy98
approved these changes
Jun 11, 2026
THardy98
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
just leaving it here that there was an idea to potentially add annotations on the wit types to identify to/from protos instead of having this model conversion helper file
dplyukhin
reviewed
Jun 11, 2026
Comment on lines
+52
to
+53
| *positional_args: object, | ||
| args: list[typing.Any] | None = ..., |
There was a problem hiding this comment.
Why do some overloads take both positional_args and args if they're mutually exclusive?
THardy98
reviewed
Jun 11, 2026
THardy98
requested changes
Jun 11, 2026
THardy98
approved these changes
Jun 11, 2026
tconley1428
commented
Jun 11, 2026
| start_delay: datetime.timedelta | None = ..., | ||
| static_summary: str | None = ..., | ||
| static_details: str | None = ..., | ||
| ) -> ExternalWorkflowHandle[WorkflowResult]: ... |
Contributor
Author
There was a problem hiding this comment.
This is actually the wrong type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WIT-generated Python bindings for Temporal system Nexus operations, starting with
WorkflowService.SignalWithStartWorkflowExecution, and exposes it asworkflow.signal_with_start_workflow.The generated call targets the server-reserved
__temporal_systemendpoint and uses the fully qualified service nametemporal.api.workflowservice.v1.WorkflowService.What changed
SignalWithStartWorkflowExecution.temporalio.workflowso newly generated operations are exposed without manual edits.Testing
Adds coverage for:
workflow.signal_with_start_workflowusing the system Nexus path