Gzip compression options#1587
Open
Sushisource wants to merge 6 commits into
Open
Conversation
Sushisource
force-pushed
the
gzip-compression
branch
2 times, most recently
from
3051a0b to
d5be198
Compare
Sushisource
force-pushed
the
gzip-compression
branch
3 times, most recently
from
5c176a5 to
30388d8
Compare
Sushisource
force-pushed
the
gzip-compression
branch
from
30388d8 to
30d71e6
Compare
tconley1428
reviewed
Jun 9, 2026
| re.compile(r"'__module__' : 'temporal\.api\.").sub, | ||
| r"'__module__' : 'temporalio.api.", | ||
| ), | ||
| partial( |
Contributor
There was a problem hiding this comment.
This replacement didn't seem to be needed for me, do we know what it's about?
Contributor
There was a problem hiding this comment.
It doesn't happen for the other dependency, protoc_gen_openapiv2
Member
Author
There was a problem hiding this comment.
It might not be needed, I just followed the pattern for the other replacements w/ the new module name
tconley1428
reviewed
Jun 9, 2026
tconley1428
reviewed
Jun 9, 2026
|
|
||
| _WORFKLOW_LINK_URL_PATH_REGEX = re.compile( | ||
| r"^/namespaces/(?P<namespace>[^/]+)/workflows/(?P<workflow_id>[^/]+)/(?P<run_id>[^/]+)/history$" | ||
| _WORKFLOW_LINK_URL_PATH_REGEX = re.compile( |
Contributor
There was a problem hiding this comment.
@VegetarianOrc should take a look at these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update core & expose options for gzip compression.
Also proto regen required a few other changes to deal with new Nexus things.
Why?
Options good!
Checklist
Closes
How was this tested:
Relies on Core tests for the meat of it. Simple tests to verify options are passed thru.
Any docs updates needed?