Skip to content

💥 refactor: payloads/memo size validation#1640

Open
jmaeagle99 wants to merge 14 commits into
mainfrom
payload-limits
Open

💥 refactor: payloads/memo size validation#1640
jmaeagle99 wants to merge 14 commits into
mainfrom
payload-limits

Conversation

@jmaeagle99

@jmaeagle99 jmaeagle99 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What was changed

  • Forward payloads/memo size enforcement options to core library since core library handles the logging and enforcement for payloads/memo size enforcement.
  • Remove all payloads/memo size enforcement implementation from Python SDK.
  • Minimize number of tests to check that options are forwarded and result in expected behavior.

Breaking Change

  • The PayloadLimitsConfig is relocated to the temporalio.client module and its fields have been renamed e.g. payload_size_warning -> payloads_warn_sizing and memo_size_warning -> memo_warn_size.
  • The DataConverter.payload_limits field has been removed in favor of specifying the limits via Client.connect.
  • The PayloadSizeWarning type has been removed.

Why?

Use core library implementation of payloads/memo size enforcement.

Checklist

  1. How was this tested: Core library tests and reduced set of Python tests.

  2. Any docs updates needed? No

Todo

  1. Wait for 💥 Payload limit enforcement sdk-rust#1363 to be merged
  2. Updated sdk-core submodule after 💥 Payload limit enforcement sdk-rust#1363 is merged.

@jmaeagle99
jmaeagle99 requested a review from a team as a code owner July 13, 2026 21:51

@tconley1428 tconley1428 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree with moving the API to client to match other languages.

@jmaeagle99 jmaeagle99 changed the title refactor: payload/memo size-limit enforcement via sdk-core 💥 refactor: payload/memo size-limit enforcement via sdk-core Jul 16, 2026
@jmaeagle99 jmaeagle99 changed the title 💥 refactor: payload/memo size-limit enforcement via sdk-core 💥 refactor: payload/memo size-limit validation Jul 17, 2026
@jmaeagle99 jmaeagle99 changed the title 💥 refactor: payload/memo size-limit validation 💥 refactor: payloads/memo size-limit validation Jul 17, 2026
@jmaeagle99 jmaeagle99 changed the title 💥 refactor: payloads/memo size-limit validation 💥 refactor: payloads/memo size validation Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants