From a247a39d0d3d40a97633e03c2df9e00a04f07fb1 Mon Sep 17 00:00:00 2001 From: aayushbaluni <73417844+aayushbaluni@users.noreply.github.com> Date: Sat, 2 May 2026 00:03:28 +0530 Subject: [PATCH] fix: clean up childWorkflowComplete entry on start failure --- packages/workflow/src/internals.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/workflow/src/internals.ts b/packages/workflow/src/internals.ts index 02f3bcb80..f3b25c4d5 100644 --- a/packages/workflow/src/internals.ts +++ b/packages/workflow/src/internals.ts @@ -628,7 +628,8 @@ export class Activator implements ActivationHandler { public resolveChildWorkflowExecutionStart( activation: coresdk.workflow_activation.IResolveChildWorkflowExecutionStart ): void { - const { resolve, reject } = this.consumeCompletion('childWorkflowStart', getSeq(activation)); + const seq = getSeq(activation); + const { resolve, reject } = this.consumeCompletion('childWorkflowStart', seq); if (activation.succeeded) { if (!activation.succeeded.runId) { throw new TypeError('Got ResolveChildWorkflowExecutionStart with no runId'); @@ -648,11 +649,13 @@ export class Activator implements ActivationHandler { activation.failed.workflowType ) ); + this.completions.childWorkflowComplete.delete(seq); } else if (activation.cancelled) { if (!activation.cancelled.failure) { throw new TypeError('Got no failure in cancelled variant'); } reject(this.failureToError(activation.cancelled.failure)); + this.completions.childWorkflowComplete.delete(seq); } else { throw new TypeError('Got ResolveChildWorkflowExecutionStart with no status'); }