Skip to content

fix: clean up childWorkflowComplete entry on child start failure #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aayushbaluni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clean up childWorkflowComplete entry on child start failure #2036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/workflow/src/internals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,8 @@ export class Activator implements ActivationHandler {
public resolveChildWorkflowExecutionStart(
activation: coresdk.workflow_activation.IResolveChildWorkflowExecutionStart
): void {
const { resolve, reject } = this.consumeCompletion('childWorkflowStart', getSeq(activation));
const seq = getSeq(activation);
const { resolve, reject } = this.consumeCompletion('childWorkflowStart', seq);
if (activation.succeeded) {
if (!activation.succeeded.runId) {
throw new TypeError('Got ResolveChildWorkflowExecutionStart with no runId');
Expand All @@ -648,11 +649,13 @@ export class Activator implements ActivationHandler {
activation.failed.workflowType
)
);
this.completions.childWorkflowComplete.delete(seq);
} else if (activation.cancelled) {
if (!activation.cancelled.failure) {
throw new TypeError('Got no failure in cancelled variant');
}
reject(this.failureToError(activation.cancelled.failure));
this.completions.childWorkflowComplete.delete(seq);
} else {
throw new TypeError('Got ResolveChildWorkflowExecutionStart with no status');
}
Expand Down