feat(common): export SDK version#2118
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
aa39135 to
095e421
Compare
Author
|
Rebased the branch on current Verification after the rebase:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public
sdkVersionexport from@temporalio/common, backed by the package version so consumers do not need to importpackage.jsonor internal package metadata directly.The new focused AVA test imports the public export and independently reads
packages/common/package.json, so it verifies the runtime wiring and version value rather than comparing the export to itself.Closes #417.
Verification
pnpm install --frozen-lockfilegit submodule update --init --recursive packages/core-bridge/sdk-corepnpm run build:protospnpm -C packages/common run buildpnpm -C packages/common run testpnpm exec prettier --check packages/common/src/index.ts packages/common/src/pkg.ts packages/common/src/__tests__/test-sdk-version.ts