Skip to content

feat(common): export SDK version#2118

Open
nanookclaw wants to merge 1 commit into
temporalio:mainfrom
nanookclaw:fix/export-sdk-version
Open

feat(common): export SDK version#2118
nanookclaw wants to merge 1 commit into
temporalio:mainfrom
nanookclaw:fix/export-sdk-version

Conversation

@nanookclaw

Copy link
Copy Markdown

Adds a public sdkVersion export from @temporalio/common, backed by the package version so consumers do not need to import package.json or internal package metadata directly.

The new focused AVA test imports the public export and independently reads packages/common/package.json, so it verifies the runtime wiring and version value rather than comparing the export to itself.

Closes #417.

Verification

  • pnpm install --frozen-lockfile
  • git submodule update --init --recursive packages/core-bridge/sdk-core
  • pnpm run build:protos
  • pnpm -C packages/common run build
  • pnpm -C packages/common run test
  • pnpm exec prettier --check packages/common/src/index.ts packages/common/src/pkg.ts packages/common/src/__tests__/test-sdk-version.ts

@nanookclaw nanookclaw requested a review from a team as a code owner June 12, 2026 11:20
@CLAassistant

CLAassistant commented Jun 12, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nanookclaw nanookclaw force-pushed the fix/export-sdk-version branch from aa39135 to 095e421 Compare June 16, 2026 04:08
@nanookclaw

Copy link
Copy Markdown
Author

Rebased the branch on current main and pushed 095e421d.

Verification after the rebase:

  • pnpm install --frozen-lockfile
  • git submodule update --init --recursive packages/core-bridge/sdk-core
  • pnpm run build:protos
  • pnpm --filter @temporalio/common run build
  • pnpm --filter @temporalio/common run test (22 passed)
  • pnpm exec prettier --check packages/common/src/index.ts packages/common/src/pkg.ts packages/common/src/__tests__/test-sdk-version.ts
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Export SDK version

2 participants