extstore gcs driver#2130
Open
cconstable wants to merge 3 commits into
Open
Conversation
cconstable
commented
Jun 18, 2026
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "name": "@temporalio/external-storage-gcs-google-sdk", | |||
| "version": "1.18.1", | |||
Contributor
Author
There was a problem hiding this comment.
this is locked to whatever sdk-ts is regardless of what is put here
cconstable
commented
Jun 18, 2026
| { | ||
| "name": "@temporalio/external-storage-gcs-google-sdk", | ||
| "version": "1.18.1", | ||
| "private": true, |
Contributor
Author
There was a problem hiding this comment.
prevents npm publish from exposing these until extstore is released. we'll want to flip this later.
cconstable
commented
Jun 18, 2026
Comment on lines
+110
to
+115
| async function allSettledOrThrow<T>(tasks: Promise<T>[]): Promise<T[]> { | ||
| const results = await Promise.allSettled(tasks); | ||
| const rejected = results.find((r): r is PromiseRejectedResult => r.status === 'rejected'); | ||
| if (rejected) throw rejected.reason; | ||
| return (results as PromiseFulfilledResult<T>[]).map((r) => r.value); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
n.b.
- S3 driver's
runAllWithAbortOnErroris concurrent and cancels in-flight sibling requests on the first failure (AWS SDK allows for cancelling mid-request). - GCS driver's
allSettledOrThrowis concurrent but doesn't attempt mid-flight cancellation.@google-cloud/storagecan't cancel an in-flight request. Abort in GCS is only check up-front.
Contributor
There was a problem hiding this comment.
Thanks for the note, helpful 👍
Contributor
Author
There was a problem hiding this comment.
Open to better names here too. These functions have the same "await all tasks" shape but they behave a little differently
THardy98
reviewed
Jun 23, 2026
cconstable
force-pushed
the
extstore-gcs-driver
branch
from
f45bcd7 to
c87aad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
@temporalio/external-storage-gcs:GcsStorageDriver+GcsStorageDriverClientinterface, no Google SDKdependency.
@temporalio/external-storage-gcs-google-sdk:GoogleCloudGcsStorageDriverClient, backed by@google-cloud/storage(peer dep).@experimentaland both packagesprivate(unpublished)Why?
Checklist