Skip to content

Add concurrent payload visitor #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cconstable wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add concurrent payload visitor #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab83f64
Add a generated payload visitor to proto package.
cconstable Jun 23, 2026
d637dc3
Add concurrent payload visitor wrapper to common.
cconstable Jun 23, 2026
b8b2491
Update payload visitor tests, names, and comments.
cconstable Jun 23, 2026
6f641b3
Fix lint issues and clarify symbol names in tests.
cconstable Jun 23, 2026
11214b6
Build payload visitor when building protos.
cconstable Jun 23, 2026
babb419
lint fixes
cconstable Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/conventions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,13 @@ jobs:
- name: Compile all non-rust code
run: pnpm --recursive --stream --filter '!@temporalio/core-bridge' --filter '!typescript-sdk' run build

- name: Check generated payload visitor is up to date
run: |
pnpm run gen:payload-visitor
if ! git diff --exit-code -- packages/proto/src/payload-visitor.generated.ts; then
echo "::error::payload-visitor.generated.ts is out of date with the protos. Run 'pnpm run gen:payload-visitor' and commit the result."
exit 1
fi
Comment on lines +54 to +60

@cconstable cconstable Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safeguard to make sure generated protos stay up to data


- run: pnpm run lint:check
- run: pnpm run lint:prune
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import importPlugin from 'eslint-plugin-import';
import prettierConfig from 'eslint-config-prettier';

export default tseslint.config(
{ ignores: ['**/node_modules/**', '**/lib/**', '**/*.js', '**/*.mjs', '**/*.cjs'] },
{ ignores: ['**/node_modules/**', '**/lib/**', '**/*.js', '**/*.mjs', '**/*.cjs', '**/*.generated.ts'] },
{
files: ['packages/*/src/**/*.ts', 'contrib/*/src/**/*.ts'],
extends: [js.configs.recommended, ...tseslint.configs.recommended, prettierConfig],
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@
"scripts": {
"rebuild": "pnpm run clean && pnpm run build",
"build": "pnpm --recursive --stream run build",
"build:watch": "pnpm run build:protos && tsc --build --watch packages/*/tsconfig.json",
"build:watch": "pnpm run build:protos && pnpm run gen:payload-visitor && tsc --build --watch packages/*/tsconfig.json",

@cconstable cconstable Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the protos package now builds the payload visitor as well. I can't think of a reason why you wouldn't want to keep them in sync but you can still run build:protos to just build the protos.

"build:protos": "tsx ./packages/proto/scripts/compile-proto.ts",
"gen:payload-visitor": "pnpm --filter @temporalio/proto run gen:payload-visitor",
"test": "pnpm --recursive --parallel --workspace-concurrency=1 --stream run test",
"test:watch": "pnpm --recursive --stream run test:watch",
"ci-stress": "node ./packages/test/lib/load/run-all-stress-ci-scenarios.js",
Expand Down
Loading
Loading