Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,10 @@ to docs, or any other relevant information.
### Changed

- protobufjs bumped to ^7.6.4
- Updated Core to `5df57f6d`. Package-visible changes from this update include:
- `NativeConnection` initialization now retries without gRPC gzip compression if the server
cannot decompress the eager `GetSystemInfo` call.
- Workflow replay now honors SDK flags already recorded in history even when the server does not
advertise SDK metadata support.
- OTLP metric export failures from Core's periodic metric reader are now logged through Core
telemetry.
82 changes: 51 additions & 31 deletions packages/core-bridge/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core-bridge/sdk-core
Submodule sdk-core updated 44 files
+1 −1 .github/workflows/heavy.yml
+11 −12 .github/workflows/per-pr.yml
+20 −1 CHANGELOG.md
+1 −1 Cargo.toml
+2 −2 crates/client/Cargo.toml
+120 −20 crates/client/src/lib.rs
+4 −3 crates/client/src/options_structs.rs
+149 −30 crates/client/src/schedules.rs
+7 −2 crates/common-wasm/Cargo.toml
+24 −4 crates/common-wasm/src/activity_definition.rs
+6 −1 crates/common-wasm/src/lib.rs
+1,227 −0 crates/common-wasm/src/search_attributes.rs
+5 −5 crates/common/Cargo.toml
+2 −2 crates/common/src/lib.rs
+183 −11 crates/common/src/telemetry/otel.rs
+1 −1 crates/macros/Cargo.toml
+10 −7 crates/macros/src/activities_definitions.rs
+1 −1 crates/macros/src/fsm_impl.rs
+188 −28 crates/macros/src/workflow_definitions.rs
+1 −1 crates/protos/Cargo.toml
+3 −3 crates/sdk-core-c-bridge/Cargo.toml
+10 −0 crates/sdk-core-c-bridge/src/worker.rs
+7 −7 crates/sdk-core/Cargo.toml
+98 −128 crates/sdk-core/src/internal_flags.rs
+176 −6 crates/sdk-core/tests/integ_tests/client_tests.rs
+1 −4 crates/sdk-core/tests/integ_tests/polling_tests.rs
+147 −14 crates/sdk-core/tests/integ_tests/schedule_tests.rs
+75 −0 crates/sdk-core/tests/integ_tests/update_tests.rs
+48 −0 crates/sdk-core/tests/integ_tests/workflow_tests/activities.rs
+11 −16 crates/sdk-core/tests/integ_tests/workflow_tests/continue_as_new.rs
+1 −1 crates/sdk-core/tests/integ_tests/workflow_tests/eager.rs
+21 −38 crates/sdk-core/tests/integ_tests/workflow_tests/upsert_search_attrs.rs
+6 −6 crates/sdk/Cargo.toml
+2 −1 crates/sdk/examples/saga/workflows.rs
+4 −1 crates/sdk/examples/schedules/starter.rs
+6 −8 crates/sdk/examples/search_attributes/starter.rs
+10 −14 crates/sdk/examples/search_attributes/workflows.rs
+7 −6 crates/sdk/src/activities.rs
+2 −2 crates/sdk/src/lib.rs
+3 −3 crates/workflow/Cargo.toml
+76 −81 crates/workflow/src/runtime/entry.rs
+97 −54 crates/workflow/src/runtime/instance.rs
+165 −29 crates/workflow/src/workflow_context.rs
+6 −9 crates/workflow/src/workflow_context/options.rs
17 changes: 17 additions & 0 deletions packages/test/src/test-native-connection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,20 @@ async function bindLocalhostTls(server: grpc.Server): Promise<number> {
return await util.promisify(server.bindAsync.bind(server))('127.0.0.1:0', credentials);
}

function addGetSystemInfoMock(server: grpc.Server): void {
server.addService(workflowServiceProtoDescriptor.temporal.api.workflowservice.v1.WorkflowService.service, {
getSystemInfo(
_call: grpc.ServerUnaryCall<
temporal.api.workflowservice.v1.IGetSystemInfoRequest,
temporal.api.workflowservice.v1.IGetSystemInfoResponse
>,
callback: grpc.sendUnaryData<temporal.api.workflowservice.v1.IGetSystemInfoResponse>
) {
callback(null, {});
},
});
}

test('NativeConnection.connect() throws meaningful error when passed invalid address', async (t) => {
await t.throwsAsync(NativeConnection.connect({ address: ':invalid' }), {
instanceOf: TypeError,
Expand Down Expand Up @@ -270,6 +284,7 @@ test('all WorkflowService methods are implemented', async (t) => {

test('all OperatorService methods are implemented', async (t) => {
const server = new grpc.Server();
addGetSystemInfoMock(server);
const calledMethods = new Set<string>();
server.addService(
operatorServiceProtoDescriptor.temporal.api.operatorservice.v1.OperatorService.service,
Expand Down Expand Up @@ -315,6 +330,7 @@ test('all OperatorService methods are implemented', async (t) => {

test('all HealthService methods are implemented', async (t) => {
const server = new grpc.Server();
addGetSystemInfoMock(server);
const calledMethods = new Set<string>();
server.addService(
healthServiceProtoDescriptor.grpc.health.v1.Health.service,
Expand Down Expand Up @@ -364,6 +380,7 @@ test('all HealthService methods are implemented', async (t) => {

test('all TestService methods are implemented', async (t) => {
const server = new grpc.Server();
addGetSystemInfoMock(server);
const calledMethods = new Set<string>();
server.addService(
testServiceProtoDescriptor.temporal.api.testservice.v1.TestService.service,
Expand Down
Loading