Skip to content

Fix test race flake: hot rxjs observable was emitting event before it had subscribers. #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cconstable wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix test race flake: hot rxjs observable was emitting event before it had subscribers. #2164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/test/src/test-async-completion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { randomUUID } from 'crypto';
import type { TestFn, ExecutionContext } from 'ava';
import anyTest from 'ava';
import type { Observable } from 'rxjs';
import { Subject, firstValueFrom } from 'rxjs';
import { ReplaySubject, firstValueFrom } from 'rxjs';
import { filter } from 'rxjs/operators';
import type { ConnectionLike } from '@temporalio/client';
import {
Expand Down Expand Up @@ -239,7 +239,7 @@ test('AsyncCompletionClient heartbeat with task token uses explicit activity con

if (RUN_INTEGRATION_TESTS) {
test.before(async (t) => {
const infoSubject = new Subject<Info>();
const infoSubject = new ReplaySubject<Info>();

const worker = await Worker.create({
workflowsPath: require.resolve('./workflows'),
Expand Down
Loading