Skip to content

Commit 317441c

Browse files
committed
marked a bad design of this solution'
1 parent 9a5ce0a commit 317441c

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

chasm/tree.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2185,6 +2185,9 @@ func (n *Node) closeTransactionHandleTimeSkipping() error {
21852185
}
21862186

21872187
// step4: record and regenerate
2188+
// todo: a bad design of current implementation is that RecordTimeSkippingTransition called regenerateChasmFastForwardWakeTask
2189+
// for chasm-based executions, and this is a special treatment. And we also need this special treatment for passive cluster.
2190+
// The reason is current chasm MutableContext.AddTask requires a component.
21882191
if err := n.backend.RecordTimeSkippingTransition(context.Background(), *transition, n.ArchetypeID()); err != nil {
21892192
return err
21902193
}

0 commit comments

Comments
 (0)